358994 - Unfork Tb's customizeToolbar

Status: RESOLVED DUPLICATE of bug 363981

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

Now that toolkit's customizeToolbar.xul doesn't include browser stylesheets (bug 250793), Thunderbird can use it rather than having to maintain its own copy. We just need to decide what post-fork things need to be in toolkit's copy, and what browser changes to toolkit's copy do or don't work for everybody.

I assume that whether or not browser wants a cancel button, now that it's not a pretend-sheet any more (at least, that may be the unstated reason why bug 174957 was wontfixed, who can tell with bugs from that era?), that Tb's reasons for wanting it from bug 227215 still hold. Easy enough, either way.

Sizing seems to be the other primary difference: in bug 212540 toolkit's copy got better big-sizing, persisting size and letting locales specify a bigger default size if they have very long words, at the expense of not shrinking when  it doesn't have enough screen to fit. Does Tb have a mandate to work on tinier screens than Fx, so it needs to keep the shrink-to-fit?

Comment 1

[Scott MacGregor]

No special mandate Phil. I think you've got a green light as long as we can keep the cancel button :)

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Bryan, thoughts?

Comment 3

[Philip Chee]

I'm -><- this close to getting customizable toolbars working in SeaMonkey as a perquisite to getting Lightning working in SeaMonkey. It would be nice for the Calendar developers not to have to work with two divergent implementations.

Comment 4

[Philip Chee]

I think one way forward is to make the toolkit widget extensible using some sort of hook or callback API like the pageInfo onLoad[]/onUnload[] registry that allows extensions to hook in to the pageInfo window. Neil is threatening to fork the toolkit code because we are finding it difficult getting the changes we want accepted by the toolkit peers.

Also, the last time I looked into what Lightning was doing I noticed that it overlaid the Thunderbird XUL and JS and replaced large chunks of functions with their own mutant versions. It might be good to get the Sunbird/Lightning developers in on this and to get their feedback on what they want/need from Thunderbird (and SeaMonkey) in order to support their rather convoluted mini-toolbar widget.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

just to note that the lightning toolbar is planned to go away ( bug 454935 ) in favour of a new tb toolbar ( bug 452281 ).  I'm not sure what effect that has on this work though which seems like a good idea from my very zoomed out perspective.

Comment 6

[Philip Chee]

Sorry, the description of  Bug 452281 (new search centric toolbar) didn't appear to involve Lightning, neither did first few comments. Perhaps someone should change the summary to "New search centric+lightning toolbar"?

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

the new toolbar is focused on search and the few global buttons that make the most sense on the toolbar.  It doesn't accommodate lightning buttons, or really mail buttons either (other than write and download).

see the other calendar integration bugs
bug 454931 - move away from current mode buttons
bug 454933 - move month, week, day mode buttons into calendar view

Comment 8

[Phil Ringnalda (:philor)]

Fixed in bug 363981