User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a1) Gecko/20061108 Minefield/3.0a1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a1) Gecko/20061108 Minefield/3.0a1 PRINT (ctrl+p) dialog box does not does not follows vista style dialog box see attached screenshot Reproducible: Always
Created attachment 245073 [details] screenshot side by side screenshot of firefox's print dialog box with notepad's print dialog box
Notepad's print dialog has looked like that since XP, so it's not specific to Vista.
(In reply to comment #2) > Notepad's print dialog has looked like that since XP, so it's not specific to > Vista. > i think you mistype that. does it should be: Firefox's print dialog has looked like that since XP, so it's not specific to Vista.
It's not only that this seems to be an old print dialog, the accesskeys in there are not very good chosen, see bug 357250.
Not a blocker, and we'll need to figure out if there's a way that we can do this so that it looks good on XP and Vista at the same time.
It looks like we need to use PrintDlgEx instead of PrintDlg. There is code to use PrintDlg but it is currently #ifdefed out.
Created attachment 349288 [details] [diff] [review] A hacky patch that causes us to use PrintDlgEx This is a start on reenabling the old code that used PrintDlgEx. It has rotted significantly so it will take more work to produce a decent patch.
is the patch attached ready for review? and who can review that.?
I know there is a project to improve the print dialog on Windows somewhere, but I don't know which bug that is. In any case, we should try to match the OS where we can, so I assume that's all the uiwanted that is needed for this bug. :)