PRINT (ctrl+p) dialog box does not follow XP or Vista style dialog box

NEW
Unassigned

Status

()

Firefox
Shell Integration
11 years ago
6 years ago

People

(Reporter: -fullmetaljacket-, Unassigned)

Tracking

(Blocks: 1 bug, {polish})

Trunk
x86
All
polish
Points:
---
Bug Flags:
blocking-firefox3 -
wanted-firefox3 +
wanted-firefox3.5 ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a1) Gecko/20061108 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a1) Gecko/20061108 Minefield/3.0a1

PRINT (ctrl+p) dialog box does not does not follows vista style dialog box

see attached screenshot

Reproducible: Always
(Reporter)

Comment 1

11 years ago
Created attachment 245073 [details]
screenshot

side by side screenshot of firefox's print dialog box with notepad's print dialog box
(Reporter)

Updated

11 years ago
OS: Windows XP → Windows Vista
Version: unspecified → Trunk

Comment 2

11 years ago
Notepad's print dialog has looked like that since XP, so it's not specific to Vista.
OS: Windows Vista → Windows XP
Summary: PRINT (ctrl+p) dialog box does not does not follows vista style dialog box → PRINT (ctrl+p) dialog box does not does not follow XP or Vista style dialog box
(Reporter)

Comment 3

11 years ago
(In reply to comment #2)
> Notepad's print dialog has looked like that since XP, so it's not specific to
> Vista.
> 

i think you mistype that. does it should be:

Firefox's print dialog has looked like that since XP, so it's not specific to
Vista.


Updated

11 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 4

11 years ago
It's not only that this seems to be an old print dialog, the accesskeys in there are not very good chosen, see bug 357250.
(Reporter)

Updated

11 years ago
Flags: blocking-firefox3?
Not a blocker, and we'll need to figure out if there's a way that we can do this so that it looks good on XP and Vista at the same time.
Flags: blocking-firefox3? → blocking-firefox3-
Keywords: polish, uiwanted
Whiteboard: [wanted-firefox3]

Updated

10 years ago
OS: Windows XP → All
Summary: PRINT (ctrl+p) dialog box does not does not follow XP or Vista style dialog box → PRINT (ctrl+p) dialog box does not follow XP or Vista style dialog box
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
It looks like we need to use PrintDlgEx instead of PrintDlg. There is code to use PrintDlg but it is currently #ifdefed out.
(Reporter)

Updated

9 years ago
Flags: wanted-firefox3.1?
Created attachment 349288 [details] [diff] [review]
A hacky patch that causes us to use PrintDlgEx

This is a start on reenabling the old code that used PrintDlgEx. It has rotted significantly so it will take more work to produce a decent patch.
(Reporter)

Comment 8

9 years ago
is the patch attached ready for review? and who can review that.?

Updated

7 years ago
Blocks: 125824
I know there is a project to improve the print dialog on Windows somewhere, but I don't know which bug that is. In any case, we should try to match the OS where we can, so I assume that's all the uiwanted that is needed for this bug. :)
Keywords: uiwanted
You need to log in before you can comment on or make changes to this bug.