360244 - Implement gfxPlatformMac::GetFontList to get list of fonts on the mac

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Håkan Waara]

Mac OS X 10.4.8, Firefox trunk.

Open the Preferences, and click the Content category. See the font menu is empty, with empty items.

For screenshot, see attachment 245201 [details].

Comment 1

[Håkan Waara]

*** Bug 360238 has been marked as a duplicate of this bug. ***

Comment 2

[:Gavin Sharp [email: [e-mail]]]

This sounds like a duplicate of bug 346831. Has bug 347421 regressed?

Comment 3

[Håkan Waara]

*** Bug 361244 has been marked as a duplicate of this bug. ***

Comment 4

[Josh Aas]

This is a problem with thebes font code.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

gfxPlatformMac::GetFontList needs to be implemented here.  I'll take a look tomorrow or wednesday, hopefully.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Vlad:

Please review the patch of bug 352174 before this.
Because we should implement |gfxPlatform::ResolveFontName| at same time.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: implement GetFontList

Implement GetFontList on the mac.  Additional problem is that the chosen font doesn't seem to actually /do/ anything, but that's for another bug.  Also, non-latin fonts aren't separated out like they are on other platforms.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

(ignore the junk localstore.rdf changes)

Comment 9

[Stuart Parmenter]

Comment on attachment 246195 [details] [diff] [review]
implement GetFontList

ok.. file another bug for the langgroup and generic family stuff.

Comment 10

[Wayne Woods]

(In reply to comment #7)
> Additional problem is that the chosen font
> doesn't seem to actually /do/ anything, but that's for another bug.  Also,
> non-latin fonts aren't separated out like they are on other platforms.

Would this be the reason that the wrong font is used in Bugzilla pages now that Thebes is implemented?

(In reply to comment #9)
> ok.. file another bug for the langgroup and generic family stuff.

Was a bug filed? I couldn't find anything, but maybe I missed it. I was going to file something for the effects I'm seeing, but I figured it was better left for someone who knew the technical details. :)

Comment 11

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yes, bug 347421 (marked as blocking this).

Comment 12

[Phil Ringnalda (:philor)]

By bug 347421 ("xforms is part of the default build"), do you mean bug 361446 ("gfxPlatformMac::GetFontList needs to use langGroup/generic family arguments")?

Comment 13

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yes.  Yes I do.