360908 - Account Wizard says to click 'Finish' when button is labeled 'Done'

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Hiro]

When bug358080 was examined, this problem was found. 
see screen shot.

Reproducible: Always

Comment 1

[Hiro]

Attachment: Screen shot of Account Wizard

Comment 2

[Hiro]

Attachment: Proposal patch

The correction is the same as bug358080.

Comment 3

[Hiro]

Scott-san,
Can review be done?

Comment 4

[Scott MacGregor]

Comment on attachment 245753 [details] [diff] [review]
Proposal patch

If I remember correctly, Neil likes to discourage me from using the xul pre-processor in shared chrome with the suite :).

Comment 5

[[e-mail]]

Comment on attachment 245753 [details] [diff] [review]
Proposal patch

I didn't even realise that toolkit's wizard says Done on the Mac - I don't think xpfe's does, although that could be changed...

Comment 6

[Hiro]

(In reply to comment #5)
> (From update of attachment 245753 [details] [diff] [review] [edit])
> I didn't even realise that toolkit's wizard says Done on the Mac - I don't
> think xpfe's does, although that could be changed...
> 

Oh...
In Seamonkey, the message and the label of the button are "Finish".
I was convinced that the label of the button was "Done"... 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061206 SeaMonkey/1.5a

Should I not change the resource of Seamonkey?

Comment 7

[Hiro]

Attachment: Update proposal patch

SeaMonkey is "Finish".

Comment 8

[[e-mail]]

Comment on attachment 245753 [details] [diff] [review]
Proposal patch

I'll go with this patch. I've checked and we ought to rename our Finish button to Done on the Mac anyway.

Comment 9

[[e-mail]]

(In reply to comment #4)
>If I remember correctly, Neil likes to discourage me from using the xul
>pre-processor in shared chrome with the suite :).
If this was SeaMonkey-only, then we would have put the wizard strings in chrome://global-platform/locale/wizard.dtd and included them here.

Comment 10

[Scott MacGregor]

We can't take this patch on the branch because we've already frozen strings for thunderbird 2.

Comment 11

[Scott MacGregor]

Comment on attachment 247963 [details] [diff] [review]
Update proposal patch

sr=mscott since it is ok with Neil.

Comment 12

[Hiro]

(In reply to comment #11)
> (From update of attachment 247963 [details] [diff] [review] [edit])
> sr=mscott since it is ok with Neil.
> 

Thank you review, Neil-san, Scott-san.
Please check-in this patch.

And if the label is changed into "Done" with SeaMonkey, it is likely to treat due to another bug. 

Comment 13

[Hiro]

Attachment: Change button label of SeaMonkey

>If this was SeaMonkey-only, then we would have put the wizard strings in
>chrome://global-platform/locale/wizard.dtd and included them here.

This has been changed.

Comment 14

[[e-mail]]

Comment on attachment 249985 [details] [diff] [review]
Change button label of SeaMonkey 

Asaf Romano tells me that "Next >" should also be "Continue" and "< Back" should be "Go Back".

Comment 15

[Hiro]

Attachment: Update SeaMonkey patch

>Asaf Romano tells me that "Next >" should also be "Continue" and "< Back"
>should be "Go Back".

The label was matched as much as Toolkit. 
http://lxr.mozilla.org/seamonkey/source/toolkit/locales/en-US/chrome/global/wizard.dtd

Comment 16

[Hiro]

Comment on attachment 250010 [details] [diff] [review]
Update SeaMonkey patch

Sorry spam.
It made a mistake in the upload file.

Comment 17

[Hiro]

Attachment: Update SeaMonkey patch

Comment 18

[[e-mail]]

Comment on attachment 250011 [details] [diff] [review]
Update SeaMonkey patch

I checked this in. In fact, I had already checked in the previous attachment, because its review hadn't yet been cancelled by then...

Comment 19

[Hiro]

(In reply to comment #18)
> (From update of attachment 250011 [details] [diff] [review])
> I checked this in. In fact, I had already checked in the previous attachment,
> because its review hadn't yet been cancelled by then...
> 
Sorry Neil-san.
And thank you review and check-in.

It reconciled by this about the account wizard. 
Please do file newly when the label is not suitable for Mac in other parts.