361664 - Tab bar changes height by 1px when opening more than one tab

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Kurt Jaeke]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

When "Always show the Tab Bar" is enabled, and there's only one tab open, opening a second tab will make the tab bar 1px higher than before.

Reproducible: Always

Steps to Reproduce:
1. Check "Always show the Tab Bar" in Tabs options
2. open new window
3. hit Ctrl-T to open new tab
Actual Results:  
Tab Bar gets bigger in height by 1px.

Expected Results:  
Tab Bar should keep its size.

Comment 1

[Kurt Jaeke]

Attachment: Screenshot combination showing height of Tab Bar with one and 2 tabs open

This is a combination of 2 screenshots showing the different heights of the Tab Bar, with one and two tabs opened.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Bug 246186 was supposedly fixed by bug 308396, I guess the visual refresh regressed it? Is this Mac-only?

Comment 3

[Kurt Jaeke]

Attachment: Screenshot combination of Gnome Desktop shows correct behavior

Seems to be a Mac only issue. This behavior cannot be reproduced on Linux/Gnome.

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 362440 has been marked as a duplicate of this bug. ***

Comment 5

[Daniel Veditz [:dveditz]]

beltzner wants this, assigning to him to find an appropriate owner. Otherwise we have to pull it off the branch list.

Comment 6

[Jay Patel [:jay]]

beltzner:  If you want this on the branch, please find an owner and get a patch together for next time.  Not blocking for this.

Comment 7

[u294409]

This is true for Trunk@Linux now, but not by 1px but by 3px.

Comment 8

[Francesco Castellana]

Attachment: Linux screenshot with the new Clearlooks 2.14 engine

This is particularly visible with the new Clearlooks gtk+ 2.14 engine, where the close button goes over the blue line on the top of the tab.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032004 Minefield/3.0b5pre Firefox/3.0

Comment 9

[u294409]

@Francesco: I said this somewhere. Clearlooks Trunk and Firefox Nightly.

Comment 10

[Francesco Castellana]

(In reply to comment #9)
> @Francesco: I said this somewhere. Clearlooks Trunk and Firefox Nightly.
> 

In comment #7 you wrote:

> This is true for Trunk@Linux now, but not by 1px but by 3px.
> 

...but what I wanted to point out is that, with the new default gtk+ engine, what before was just a small annoyance now becomes graphically visible. It only applies to that particular theme, but I believe this might be important since some distributions might rely on it by default in a short time. And BTW I experience a 1px difference.

Just wanted to be more accurate.

This is still marked as Mac-only but I believe it should be changed ...or did I miss a specific bug for other OS's?

Comment 11

[u294409]

I see this bug on ALL GTK themes.

And this is not OSX only.

Comment 12

[Grey Nicholson (they/them)]

If anything, this would've been resolved fixed by bug 419712. (I'm not running trunk, so I don't know whether this is actually fixed.)

The problem was that a background tab with a close button was a pixel or two taller than either a background tab without a close button, or the foreground tab with (or without) a close button.

This meant that opening a second tab (which by default has a close button) increased the tab bar's height.

You can test this by opening two tabs and varying browser.tabs.closeButtons {0|1|2} in about:config

Set to 1, the default, the background tabs + close buttons grow a couple of pixels.

Comment 13

[Dão Gottwald [:dao]]

This was filed for OS X and incorrectly changed to "All". Gnomestripe is bug 541864.