361701 - First pane of preferences window is blank when animating is on

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Hiro]

Firefox and Thunderbird, it always empties when Preference is opened first. 
See screen shot.

Mac OS X 10.3.9
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1.1pre) Gecko/20061123 BonEcho/2.0.0.1pre

Comment 1

[Hiro]

Attachment: screen shot

When other set panels are clicked, all panels are normally displayed.

Comment 2

[philippe (part-time)]

*** This bug has been marked as a duplicate of 361243 ***

Comment 3

[philippe (part-time)]

This regressed between 20061120 and 20061121.
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-20+00%3A00%3A00&maxdate=2006-11-21+03%3A00%3A01&cvsroot=%2Fcvsroot

Comment 4

[Hiro]

The patch of bug355469 was done in backout and tried. 
https://bugzilla.mozilla.org/attachment.cgi?id=241758

This problem has recovered by backout of the patch. 

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Does this affect Firefox 2.0.0.1pre nightlies too?

Comment 6

[Dave Townsend [:mossop]]

Attachment: force visibility when not animating

When a prefwindow is set to animate the default opacity for a prefpane is 0. So when the first pane doesn't animate we must make it visible.

Comment 7

[Dave Townsend [:mossop]]

*** Bug 361747 has been marked as a duplicate of this bug. ***

Comment 8

[Dave Townsend [:mossop]]

Attachment: Remove default visibility settings

The current state of the code doesn't actually use the opacity settings from the stylesheets. The first pane should be opaque anyway (this bug), and when animating to the next pane its opacity is set to 0 as it is selected.

The animate attribute only appears to be used as part of the selector in the stylesheet.

This has been tested with no noticeable visual regressions on a windows machine.

Comment 9

[Dave Townsend [:mossop]]

bug 355469 was backed out from the branch so this is no longer an issue there.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 246495 [details] [diff] [review]
Remove default visibility settings

r=mano, thanks.

Comment 11

[Asaf Romano (gone)]

mozilla/toolkit/content/xul.css 1.89
mozilla/toolkit/content/widgets/preferences.xml 1.58

Comment 12

[Benjamin Smedberg]

Does this bug need a unit test?