Closed
Bug 361711
Opened 18 years ago
Closed 18 years ago
Toolbar customization broken on trunk by wrong_document_err
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: philor)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
2.52 KB,
patch
|
mscott
:
review+
|
Details | Diff | Splinter Review |
Trunk-only, Tb version of bug 361627: both wrappers and palette items cloned from toolbars need to be properly adopted before being stuffed into a new document. The nice part is, the second fix of bug 288079 already gave us what the toolkit version doesn't yet have, only unwrapped items going through the currentset setter, so just three adoptNode()s does the trick.
|
Assignee | |
Updated•18 years ago
|
Blocks: 47903
Keywords: regression
|
|
Assignee | |
Comment 2•18 years ago
|
||
Well, okay, actually it's not wrapped items killing toolkit, it's pre-existing unhappiness about removing bookmark items. Still, undue gloating aside, this is the right fix for this fork.
|
||
Updated•18 years ago
|
Attachment #246449 -
Flags: review?(mscott) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
mail/base/content/customizeToolbar.js 1.11
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•