363043 - Unfork Sb's customizeToolbar

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Phil Ringnalda (:philor)]

Once bug 359656 lands, it's just a matter of a little #ifdef-wrapped % style and packaging the XUL file from toolkit/.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Approach 1

Unfortunately, I didn't get home with enough time to land the bug 359656 patch before the reflow tree closure tonight, but if you imagine that checked in, this is my probably-preferred approach: we could just alias chrome://calendar/content/customizeToolbar.xul to the toolkit URL in the jar.mn instead, and just have one openDialog, if you really don't want to preprocess calendar.js, but that seems less likely to get cleaned up properly when you decide to get rid of the 1.8branch ifdefs somewhere down the line.

Comment 2

[Stefan Sitter [:ssitter]]

*** Bug 358386 has been marked as a duplicate of this bug. ***

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 247928 [details] [diff] [review]
Approach 1

Yeah, I think this is the best way to be obvious about what we're doing, and thus catch the attention of J. Random Toolkithacker when he's mucking with callers of chrome://global/content/customizeToolbar.xul

Comment 4

[Joey Minta]

Comment on attachment 247928 [details] [diff] [review]
Approach 1

r=jminta

Comment 5

[Phil Ringnalda (:philor)]

Trunk:
calendar/sunbird/base/jar.mn 1.15
calendar/resources/content/calendar.js 1.247
calendar/resources/jar.mn 1.146

Branch:
calendar/sunbird/base/jar.mn 1.9.2.6
calendar/resources/content/calendar.js 1.200.2.36
calendar/resources/jar.mn 1.114.2.31

Welcome back :)