Closed
Bug 364316
Opened 18 years ago
Closed 17 years ago
[places] some favicons in the history sidebar and the bookmarks dialog (if --enable-places-bookmarks) are bigger than 16px by 16px
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha2
People
(Reporter: moco, Unassigned)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
18.18 KB,
image/png
|
Details | |
3.03 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
some favions in the history side bar are bigger than 16x16 I've fought this battle before (with the "all tabs menu") and the solution was some css to make the favicons be 16x16. here comes a screen shot
Reporter | ||
Comment 1•18 years ago
|
||
Reporter | ||
Comment 2•18 years ago
|
||
for the url that exposes this problem, see http://www.nps.gov/alcatraz/
Updated•18 years ago
|
Summary: some favions in the history side bar are bigger than 16x16 → some favicons in the history side bar are bigger than 16x16
Reporter | ||
Comment 3•18 years ago
|
||
for the rdf based bookmarks sidebar, I believe the reason we don't see this problem is this rule from chrome://browser/content/bookmarks/bookmarks.css (http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarks.css) treechildren::-moz-tree-image(Name) { width:16px; height:16px; }
Reporter | ||
Comment 4•18 years ago
|
||
I've got a patch, but still need to test on mac. for the bookmarks, the rules are in mozilla/browser/components/bookmarks/content/bookmarks.css, but that seems odd to me. (why in content and not the theme?) I could have made the fix to http://lxr.mozilla.org/seamonkey/source/browser/components/places/content/places.css, but I've put it in browser/theme. i'll ping gavin (or mano) to see what they think.
Assignee: nobody → sspitzer
Target Milestone: --- → Firefox 3 alpha1
Version: 2.0 Branch → Trunk
Reporter | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Summary: some favicons in the history side bar are bigger than 16x16 → [places] some favicons in the history side bar are bigger than 16x16
Reporter | ||
Comment 5•18 years ago
|
||
note, I'm removing some duplicate rules from the pinstripe places.css
Comment 6•18 years ago
|
||
+1 for moving this browser/themes/
Comment 7•18 years ago
|
||
s/this/this to
Reporter | ||
Comment 8•18 years ago
|
||
Comment on attachment 249213 [details] [diff] [review] patch ok, I've tested on mac as well. mac has this bug, and this fixed the problem in the history sidebar as well as the places based bookmarks dialog
Attachment #249213 -
Attachment description: patch (still need to test on mac) → patch
Attachment #249213 -
Flags: review?(mano)
Comment 9•18 years ago
|
||
Comment on attachment 249213 [details] [diff] [review] patch r=mano.
Attachment #249213 -
Flags: review?(mano) → review+
Reporter | ||
Updated•18 years ago
|
Summary: [places] some favicons in the history side bar are bigger than 16x16 → [places] some favicons in the history sidebar and the bookmarks dialog (if --enable-places-bookmarks) are bigger than 16px by 16px
Reporter | ||
Comment 10•18 years ago
|
||
fixed, thanks for the review asaf.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: Firefox 3 alpha1 → Firefox 3 alpha2
Reporter | ||
Comment 12•17 years ago
|
||
reopening, this regressed recently.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 13•17 years ago
|
||
note: when fixing this, be careful not to regress bug #334669
Assignee: sspitzer → nobody
Status: REOPENED → NEW
Comment 14•17 years ago
|
||
i'v just post fix in bug #334669
Reporter | ||
Comment 15•17 years ago
|
||
> i'v just post fix in bug #334669
thanks onemen.one for the quick fix. I've just landed it, and this bug is fixed again.
Status: NEW → RESOLVED
Closed: 18 years ago → 17 years ago
Resolution: --- → FIXED
Comment 16•17 years ago
|
||
verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007080805 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
Comment 17•16 years ago
|
||
Can someone explain why treechildren::-moz-tree-image(Name) { width:16px; height:16px; } constrains icons to 16px, while treechildren::-moz-tree-image(Name) { max-width:16px; max-height:16px; } does not?
Component: History → Bookmarks & History
QA Contact: history → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•