334669 - bookmark separators have an icon overlaid over it

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Régis Caspar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060419 Firefox/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060419 Firefox/3.0a1

In the place window, separators have a "document" icon overlaid over it (see attached screenshot)

Reproducible: Always

Steps to Reproduce:
1. Open place dialog 
2. Look for a separator or creates one
3. Look at this separator

Actual Results:  
icon overlaid over the separator

Expected Results:  
normal separator (i.e. straight line without any icon)

patch for #329367 looks like a good culprit...

Comment 1

[Régis Caspar]

Attachment: screenshot

screenshot showing the problem

Comment 2

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070406 Minefield/3.0a4pre ID:2007040604 [enable-places-bookmarks]

still happens, in Bookmarks Manager and in sidebar-bookmarks.

Comment 3

[tabmix.onemen]

Attachment: patch for winstripe

Comment 4

[Asaf Romano (gone)]

Comment on attachment 263101 [details] [diff] [review]
patch for winstripe

Sorry for latency, r=mano.

Comment 5

[Asaf Romano (gone)]

mozilla/browser/themes/winstripe/browser/places/places.css 1.10

Comment 6

[(not reading, please use [e-mail] instead)]

asaf and [e-mail]:  I think this regressed the fix for bug #364316.

the fix for that bug included some rules to keep favicons at 16x16 in the bm manager and history sidebar (for example).

Comment 7

[tabmix.onemen]

Attachment: keep favicons at 16x16

Comment 8

[Asaf Romano (gone)]

Comment on attachment 264386 [details] [diff] [review]
keep favicons at 16x16

>Index: browser/themes/winstripe/browser/places/places.css
>===================================================================
>+treechildren::-moz-tree-image(title) {
>+  width: 16px;
>+  height: 16px;
>+}
>+
>+treechildren::-moz-tree-image(title, separator) {
>+  width: 0px !important;
>+  height: 0px !important;
>+}
>+

you don't need !important here, I think. also, s/0px/0/.

r=mano otherwise.

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: onemen.one patch to keep favicons at 16x16 + asaf's suggestions (tested on win32)

Comment 10

[(not reading, please use [e-mail] instead)]

fixed landed, thanks onemen.one!

Checking in browser/components/places/content/treeView.js;
/cvsroot/mozilla/browser/components/places/content/treeView.js,v  <--  treeView.
js
new revision: 1.6; previous revision: 1.5
done
Checking in browser/themes/winstripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/places/places.css,v  <--  plac
es.css
new revision: 1.11; previous revision: 1.10
done

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: screen shot from the mac

It appears that pinstripe has a similar problem

Comment 12

[(not reading, please use [e-mail] instead)]

> It appears that pinstripe has a similar problem

spun off to bug #380703

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv