364483 - Firefox stays elevated after update

Status: RESOLVED DUPLICATE of bug 367540

(Toolkit :: Application Update, defect)

Description

[Masatoshi Kimura [:emk]]

I have updated Firefox 2.0 to 2.0.0.1.
After update, Fx started automatically with elevated privilege.
Some users may continue to browse using elevated Fx. (thanks to the session restore!)
Updater should be "un-elevated" before launching Fx.

Comment 1

[Jay Patel [:jay]]

We need some one to take a look at this ASAP... rstrong or sspitzer perhaps?  We need this for 2.0.0.2.

Comment 2

[Masatoshi Kimura [:emk]]

My patch attached to bug 351949 also fix this.
Rstrong, Please hurry up review.

Comment 3

[Masatoshi Kimura [:emk]]

Sorry, I have no enough time to make a new patch, test, request review, ask for approval until code freeze.
Anyway, my patch didn't work when updating from 2.0.0.1 (or earlier) because old updater has no ability to "un-elevate". Firefox.exe should relaunch itself to drop the elevated priv after post-update.
Reassigning to rstrong because bug 351949 is also reassigned.

Comment 4

[(not reading, please use [e-mail] instead)]

robert tells me that bug #351949 contains the fix for this.

thanks again to 

Comment 5

[(not reading, please use [e-mail] instead)]

> thanks again to 

thanks again to Masatoshi Kimura for working on our Vista support!

Comment 6

[Robert Strong (they/them - no direct email)]

note: this is not fixed for 1.8.1.2 but will be for 1.8.1.3 by the patch that landed in bug #351949. I will look into what we might be able to do for 1.8.1.2 as time permits

Comment 7

[Robert Strong (they/them - no direct email)]

Resolving as duplicate of bug 367540 since that is where the patch is

Comment 8

[(not reading, please use [e-mail] instead)]

fixed on the branch.

Comment 9

[Robert Strong (they/them - no direct email)]

To verify this you must get the UAC dialog (e.g. allow / cancel) and not the runas dialog. When launching the app you should not be able to save a web page in the root of the c: drive.

note: with trunk it wasn't possible to save to the root of the c: drive since the trunk didn't have the shim to elevate the updater.exe

Comment 10

[Marcia Knous [:marcia]]

verified on the 1.8 branch using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.2pre) Gecko/2007021503 BonEcho/2.0.0.2pre. Verified using rstrong Comment 9 - I get the allow/cancel dialog (albeit twice), and I am **unable** to save a file to the root C drive - trying to do save generates an error dialog notifying me I don't have permission to save in this location.

Thanks to rstrong for always providing good steps to verify - this is something that is greatly appreciated by QA, especially me since I am making the transition from primarily testing Mac to testing Windows and still learning many of the ins and outs of Windows.

Comment 11

[Marcia Knous [:marcia]]

verified on the 1.8 branch using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.2pre) Gecko/2007021503 BonEcho/2.0.0.2pre. Verified using rstrong Comment 9 - I get the allow/cancel dialog (albeit twice), and I am **unable** to save a file to the root C drive - trying to do save generates an error dialog notifying me I don't have permission to save in this location.

Thanks to rstrong for always providing good steps to verify - this is something that is greatly appreciated by QA, especially me since I am making the transition from primarily testing Mac to testing Windows and still learning many of the ins and outs of Windows.