365810 - Ctrl+Y for Edit->Redo broken

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Nathan Bryant]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: version 1.5.0.9 (20061207)

Undo Edit|Redo, for example Redo Delete Message if you've just undone a deletion, the menu shows Ctrl-Y as the shortcut but the actual shortcut is Ctrl-Shift-Z.

Reproducible: Always

Steps to Reproduce:
1. Do something
2. Undo it
3. Redo it
Actual Results:  
Ctrl-Shift-Z works

Expected Results:  
Ctrl-Shift-Z should be shown in the menu

Comment 1

[Simon Bünzli]

Both Ctrl+Y and Ctrl+Shift+Z work -- however on Windows Ctrl+Y is the platform standard and thus what is displayed. -> INVALID

Comment 2

[Nathan Bryant]

Ctrl+Y does not work on my system (Windows XP Service Pack 2)

Comment 3

[Simon Bünzli]

Does Ctrl+Y work in any other app which supports multi-level undo (e.g. Internet Explorer, WordPad, Word, etc.)?

If so, do you have any extensions installed or did you test on a clean profile?

Comment 4

[Nathan Bryant]

In Word, Ctrl+Y works.

I don't THINK I have any extensions installed, unless Flash, Quicktime, etc integrate with Thunderbird. I don't think they do...

In a clean profile, both Ctrl+Y and Ctrl+Shift+Z work.

I think this profile may have been originally imported from Outlook...

Comment 5

[Simon Bünzli]

(In reply to comment #4)
> I don't THINK I have any extensions installed,

Tools -> Extensions shows you the list.

> In a clean profile, both Ctrl+Y and Ctrl+Shift+Z work.

So we need additional steps to reproduce... Maybe having a look at Tools -> JavaScript Console and checking whether it contains any error messages (before and after you hit Ctrl+Y) gives an additional hint.

Comment 6

[Stefan Sitter [:ssitter]]

I can confirm this behavior using Mozilla/5.0 (Windows; U; Windows NT 5.0; de; rv:1.8.0.10) Gecko/20070221 Thunderbird/1.5.0.10 
and Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.4pre) Gecko/20070325 Thunderbird/2.0pre

Steps To Reproduce:
1. Go to message list and delete one email using Delete keyboard button
2. Press Ctrl+Z -> email reappears
3. Press Ctrl+Y -> nothing happens, no errors shown in JavaScript Console
4. Press Ctrl+Shift+Z -> email is deleted again

The same behavior was reported with Lightning that uses Thunderbirds Undo/Redo functionality for calendar changes (Bug 375397)

Comment 7

[Stefan Sitter [:ssitter]]

Additional information: Ctrl+Y works as expected after adding the line

  <handler event="keypress" key="y" command="cmd_redo" modifiers="accel" />

to the <binding id="browser"> section in file

  thunderbird\chrome\toolkit.jar\content\global\platformHTMLBindings.xml

Comment 9

[Nathan Bryant]

I do have one error in the Javascript console:

Error: Unknown namespace prefix 'html'.  Ruleset ignored due to bad selector.
Source File: chrome://messenger/skin/messageBody.css
Line: 55

Comment 11

[Simon Bünzli]

Attachment: make Ctrl+Y always mean redo on Windows

For some reason, Ctrl+Y seems to have been forgotten in the browser context: Ctrl+Z and Ctrl+Shift+Z are there as in all other contexts, and I don't see why Ctrl+Y shouldn't be there as well (at least on Windows).

Thanks Stefan for tracking this down.

Comment 12

[Boris Zbarsky [:bzbarsky]]

I'm probably the wrong sr for this.  It'd be better to pick someone who knows something about this code.  It'll take me a long time to get to this sr, if I ever do, because I'll need to sort out what's going on with the code and all...

Comment 13

[Simon Bünzli]

Comment on attachment 275371 [details] [diff] [review]
make Ctrl+Y always mean redo on Windows

(In reply to comment #12)
> I'm probably the wrong sr for this.
You were the last person to sr a (similar) change to that file, but sure, I can pass it on...

Comment 14

[Scott MacGregor]

Comment on attachment 275371 [details] [diff] [review]
make Ctrl+Y always mean redo on Windows

I'm afraid I'm even less qualified than bz for this one :). Let me know if you need help finding a good reviewer for this patch though Simon!

Comment 15

[[e-mail]]

Comment on attachment 275371 [details] [diff] [review]
make Ctrl+Y always mean redo on Windows

Looks reasonable to me.

Comment 16

[Aaron Leventhal]

Why was it removed? What was the bug #?

Comment 17

[Simon Bünzli]

(In reply to comment #16)
> Why was it removed? What was the bug #?

AFAICT it's never been there at all. Forgotten from the get-go?

Comment 18

[Aaron Leventhal]

Ctrl+Y works in a text area or a designMode area in Firefox 2, on Windows:
E.g. http://www.mozilla.org/editor/midasdemo/

I'm just wanting to see what bug it was removed in. Perhaps someone wanted to use the key for something else, since it's redundant with Ctrl+Shift+Z.

I remember studying this years ago, and some MS apps use Ctrl+Shift+Z, and others use Ctrl+Y. They weren't consistent. So, we decided to use both, but there was the idea, that if we were really desperate someday for another keystroke, we might steal Ctrl+Y.

Comment 19

[Simon Bünzli]

Attachment: Thunderbird-specific fix

(In reply to comment #18)
> I'm just wanting to see what bug it was removed in.

As I said: it's never been there in the first place.

If you feel however that this is as expected we could also try this Thunderbird specific hack (although in the few multi-level undo capable apps I've just tested Ctrl+Shift+Z never(!) worked and Ctrl+Y always did). I'll leave it to you and Scott which solution you prefer...

Comment 20

[Simon Bünzli]

Comment on attachment 275424 [details] [diff] [review]
Thunderbird-specific fix

Thanks, Aaron. There's no need for this hack, then.

Comment 21

[Phil Ringnalda (:philor)]

Simon: I suspect you need to figure out what core component owns platformHTMLBindings.xml and move this bug there, since the odds of whoever should be doing the approval1.9 for this triaging requests in Thunderbird are microscopically low.

Certainly not checkin-needed without it, anyway.

Comment 22

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 275371 [details] [diff] [review]
make Ctrl+Y always mean redo on Windows

a=bzbarsky

Comment 23

[Phil Ringnalda (:philor)]

content/xbl/builtin/win/platformHTMLBindings.xml 1.25