366255 - Exception thrown in nsIEditor.inlineSpellChecker when opening/closing the compose window

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Frédéric Buclin]

Thunderbird version 2 beta 1 (20070105)

Everytime I click the "Compose new message" icon in the toolbar, I get the following error:

Erreur : [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIEditor.inlineSpellChecker]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://editor/content/editorInlineSpellCheck.js :: anonymous :: line 54"  data: no]
Fichier source : chrome://editor/content/editorInlineSpellCheck.js
Ligne : 54


The corresponding code is:

var InlineSpellChecker =
{
  editor : null,
  inlineSpellChecker: null,

  Init : function (editor, enable)
  {
    this.editor = editor;
    this.inlineSpellChecker = editor.inlineSpellChecker; # This is line 54!
    this.editor.QueryInterface(Components.interfaces.nsIEditor_MOZILLA_1_8_BRANCH).setSpellcheckUserOverride(enable);
  },


The same error is thrown when closing the compose window.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Does this also happen if you run Thunderbird in Safe Mode?

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
> Does this also happen if you run Thunderbird in Safe Mode?
> 

Yes. I renamed my .thunderbird/ directory, then started thunderbird in safe mode, configured one account (a POP3 account, if that helps), and when clicking the "Compose New Message" icon, I get this error. I also get this error if I go to File > New > Message and also if I type Ctrl+N.

Tomcat told me he couldn't reproduce on FC6, using GNOME. I'm using KDE 3.5.4.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> Tomcat told me he couldn't reproduce on FC6, using GNOME. I'm using KDE 3.5.4.

What happens if you deactivate the spellchecker preferences (one or both) inside the options? 

Comment 4

[Frédéric Buclin]

(In reply to comment #3)
> What happens if you deactivate the spellchecker preferences (one or both)
> inside the options? 

They are both deactivated, already.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #4)
> > What happens if you deactivate the spellchecker preferences (one or both)
> > inside the options? 
> 
> They are both deactivated, already.

So, activate them please. Does the error still occurs?

After having a look at nsEditor.cpp the exception will be thrown here:
http://lxr.mozilla.org/seamonkey/source/editor/libeditor/base/nsEditor.cpp#1329

Frederic, does this exception occur immediately after opening the compose window or after you start writing?

Comment 6

[Frédéric Buclin]

(In reply to comment #5)
> Frederic, does this exception occur immediately after opening the compose
> window or after you start writing?

Immediately after opening the compose window

Comment 7

[Frédéric Buclin]

And yes, the error still occurs if I enable them.

Comment 8

[Frédéric Buclin]

Ohhhh.... I think I made an interesting discovery! :) The error only occurs with the french version of Tb, downloaded from ftp://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-mozilla1.8-l10n/thunderbird-2.0b1.fr.linux-i686.tar.gz

I see no error (except the one reported in bug 361702) when using the en-US version.

Maybe this is related: when starting Tb2b1 french version, I get this message:

Failed to load old-style contents.rdf at 'jar:resource:///chrome/en-US.jar!/locale/en-US/wallet/contents.rdf'.

This *could* explain why this only happens with the french version.

Note that I didn't test with other l10n tarballs. CC'ing Axel.

Comment 9

[Carsten Book [:Tomcat]]

Confirmed on Fedora FC 6 - also other Errors when trying to use the Spellchecker on the fr-FR Build:

Erreur : uncaught exception: [Exception... "Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIEditorSpellCheck.GetNextMisspelledWord]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame :: chrome://editor/content/EdSpellCheck.js :: NextWord :: line 298"  data: no]

Erreur : window.opener.InlineSpellChecker.inlineSpellChecker has no properties
Fichier source : chrome://editor/content/EdSpellCheck.js
Ligne : 590

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All localized versions seems to be affected. I additionally tested with the German localization under Windows. If you go to the spell checker tab inside options you will notice that no dictionary is installed. I followed the given link and tried to install some dictionaries. But without success. It's not possible. Is something broken for spell checker?

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dunno if it's the right component now so change it to a better one if neccessary. IMO this should be an regression but I cannot find any older release for testing.

Comment 12

[David :Bienvenu]

the claim is that beta 2.0 localized builds don't have a dictionary installed...maybe that's known, I don't know...

Comment 13

[Scott MacGregor]

I thought all locales shipped with the en-US dictionary. henrik, can you verify if that was the case in 1.5? I know most locales can't ship with their localized dictionary due to license issues.

Comment 14

[Cédric Corazza]

(In reply to comment #8)

> Failed to load old-style contents.rdf at
> 'jar:resource:///chrome/en-US.jar!/locale/en-US/wallet/contents.rdf'.
> 
> This *could* explain why this only happens with the french version.
> 
> Note that I didn't test with other l10n tarballs. CC'ing Axel.
> 

This error also occurred for other locale (I tested it with it locale) and
doesn't seem to be related to the spellchecker imo

For this error "chrome://editor/content/EdSpellCheck.js :: NextWord :: line
298"  data: no]" I couldn't reproduce it when a dictionary is installed (either
for it and fr) tested both with latest nightlies

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #13)
> I thought all locales shipped with the en-US dictionary. henrik, can you verify
> if that was the case in 1.5? I know most locales can't ship with their
> localized dictionary due to license issues.

Yeah. Thunderbird version 1.5.0.9 (20061207) does have the enUS dictionary installed. The error doesn't occur for this build. So it's a regression for the 1.8 branch.

Comment 16

[Axel Hecht [:Pike]]

For Firefox, we remove the en-US dictionary on repackaging, I bet we do for Thunderbird, too.

Comment 17

[Scott MacGregor]

(In reply to comment #16)
> For Firefox, we remove the en-US dictionary on repackaging, I bet we do for
> Thunderbird, too.
> 

Hmm, I wonder if for Thunderbird we should go back to what we did in 1.5 and always ship en-US so there's a dictionary installed.

Comment 18

[Frédéric Buclin]

(In reply to comment #17)
> Hmm, I wonder if for Thunderbird we should go back to what we did in 1.5 and
> always ship en-US so there's a dictionary installed.

Why not let the spellchecker sleeps if no dictionary is present, and avoid any call to it unless at least one dictionary is installed?

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #16)
> For Firefox, we remove the en-US dictionary on repackaging, I bet we do for
> Thunderbird, too.

Axel, is there a tracking bug for the ongoing work? And why you switch back to fr-FR?

Comment 20

[Axel Hecht [:Pike]]

(In reply to comment #19)

Oops, seems like that didn't survive the mid-air and it didn't talk about it.

Anyway, Registration is totally wrong, as this is not specific to any particular locale, I'm moving it back to the Thunderbird product. I really think that thunderbird should cope with an install without a spell checker.

Comment 21

[Scott MacGregor]

Ok, if you think the right thing to do for localized builds is to not ship the en-US dictionary, I'll make things work better when we don't have a dictionary installed.

Comment 22

[Scott MacGregor]

I believe the work I did to convert Thunderbird to use toolkit's InlineSpellCheckerUI in Bug 355064 on the trunk and the branch made this much better.

The inline spell checker no longer throws any JS errors when you start it without any dictionaries.

The only error I can trigger now is when you invoke the spell check dialog:

JavaScript error: , line 0: uncaught exception: [Exception... "Component returne
d failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIEditorSpellCheck.GetNe
xtMisspelledWord]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location:
 "JS frame :: chrome://editor/content/EdSpellCheck.js :: NextWord :: line 299"
data: no]

Comment 24

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #22)
> The only error I can trigger now is when you invoke the spell check dialog:
> 
> JavaScript error: , line 0: uncaught exception: [Exception... "Component
> returne
> d failure code: 0x80004003 (NS_ERROR_INVALID_POINTER)
> [nsIEditorSpellCheck.GetNe
> xtMisspelledWord]"  nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)" 
> location:
>  "JS frame :: chrome://editor/content/EdSpellCheck.js :: NextWord :: line 299"
> data: no]
> 

I don't see any issues with opening/closing the compose window, nor the spellcheck issue, on Thunderbird 2.0.0.12 (20080213) on Leopard anymore. Marking WFM.

Comment 25

[Frédéric Buclin]

Well, the problem has rather been FIXED.

Comment 26

[Reed Loden [:reed]]

It's not FIXED unless you can point to a bug / patch that fixed it.