366508 - Not All Filter Actions are performed when the first action moves a messsage

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

From the forums:

have a filter set on one account that uses the local folders.
The filter is set to
1. Move the mail to a specific folder in the local folders
2. Add a star
3. Add a tag

It only adds the start.. however if I set the filter to
1. Move the mail to a specific folder in the local folders
2. Add a tag
3. Add a star

It only adds the tag. It appears to be doing only the first of the subsequent actions.

Comment 1

[Scott MacGregor]

I see something a little different from the MZ reporter.

I've got an IMAP filter that does:

Move to a local folder
Star 
Tag as Important

When this filter fires, the message is moved and tagged, but no star appears. 

Regardless of the order between the last two actions, the message is always tagged and never starred.

Branch and trunk.

Comment 2

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Linux too.

Comment 3

[David :Bienvenu]

I thought (but I could be wrong) that we reorder the actions so that move is always done last, so the source message is tagged, starred, and then moved. With imap, this is going to result in urls getting queued - the tagged one should run first, followed by the star url, and then the move url. I'll try it out when I get a chance.

Comment 4

[David :Bienvenu]

but the reporter is just talking about local msgs, if I'm reading that correctly...

Comment 5

[Mike Cowperthwaite]

(In reply to comment #1)
> I've got an IMAP filter that does:
> 
> Move to a local folder
> Star 
> Tag as Important
> 
> When this filter fires, the message is moved and tagged, but no star appears. 

That's bug 254589.  Interesting that it works with tags -- apparently adding a label also used to fail.  (Because label wasn't handled with a custom header?)

Comment 7

[David :Bienvenu]

Attachment: proposed fix

the bug really has to do with filters moving messages that have been starred - tagging is not really relevant. The issue is simply that we weren't storing the mark in the DB, so it wasn't getting copied over.

Labelling used to have this same bug, but tagging fixed that.

Comment 8

[Scott MacGregor]

I only saw the starred issue which this patch fixes. Some folks see a problem with tags not getting applied when the filter does a move too:

http://forums.mozillazine.org/viewtopic.php?p=2735512#2735512

Maybe we should break that part into a new bug (that's also want the original reporter was seeing)

Comment 9

[David :Bienvenu]

I can open a new bug for that - marking this fixed on trunk and branch.

Comment 10

[David :Bienvenu]

Bug 369745 filed for the tags issue.