366935 - Drop BrowserController

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

The BrowserController object was added for updating the places version of the bookmark-all-tabs command. However, it sure doesn't work as well as you would think since it listens to onselect rather than TabOpen/Close (*Sigh*, we already fixed this bug once for the bookmarks-based implementation). This approach is an overkill IMO and may hurt performance for no good reason (we're going through another command controller for each event).

I will fix the bookmark-all-tabs command enabled-state in a separate bug.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[Asaf Romano (gone)]

Attachment: patch

We had the same command listed twice.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 251514 [details] [diff] [review]
patch

More-complete patch on bug 367025.

Comment 5

[Asaf Romano (gone)]

Fixed by bug 367025.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv