Closed Bug 367991 Opened 18 years ago Closed 15 years ago

Remove unused places calendar widget and advanced query builder code

Categories

(Firefox :: Bookmarks & History, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Firefox 3.7a1

People

(Reporter: asaf, Assigned: mak)

References

Details

Attachments

(1 file, 2 obsolete files)

Remove the places-specific calendar widget.

Right now, it's only used by advanced-search UI which is kinda broken already. We can use the shared calendar widget (bug 92174) if we ever make this UI work again.
Attached patch remove it (obsolete) — Splinter Review
Attachment #252532 - Flags: review?(sspitzer)
Comment on attachment 252532 [details] [diff] [review]
remove it

r=sspitzer
Attachment #252532 - Flags: review?(sspitzer) → review+
Whiteboard: [checkin needed]
Target Milestone: Firefox 3 alpha2 → Firefox 3 alpha5
Target Milestone: Firefox 3 alpha5 → Firefox 3 beta1
Flags: blocking-firefox3?
Comment on attachment 252532 [details] [diff] [review]
remove it

Patch checked in.
Attachment #252532 - Attachment description: remove it → remove it (checked in)
Whiteboard: [checkin needed]
kherron+mozilla@fmailbox.com: Please back this out (and please, don't checkin my patches), I didn't check this in yet because it breaks the current advanced search UI.
Backed out. If you didn't want it checked in, then why was the "[checkin needed]" status set?
Flags: blocking-firefox3? → blocking-firefox3+
Blocks: 329397
Mano, can this reland, or do we still have the same issue?
Missing the freeze, moving out.
Target Milestone: Firefox 3 M7 → Firefox 3 M8
Target Milestone: Firefox 3 M8 → Firefox 3 M9
doesn't need to block beta. not sure why it's a blocker. what do you plan on replacing the widget with?
Target Milestone: Firefox 3 M9 → Firefox 3 M10
Attachment #252532 - Attachment description: remove it (checked in) → remove it
datetimepicker.xml - localized via toLocaleFormat(), accessible (both in terms of html:role and keyboard access).
places.xml - localized via "// localized stuff, FIXME: move somewhere else" and en-US strings hardcoded in the binding, no sign of even an "// a11y - make someone else add some later" comment

Other than the obscurity of the feature, sounds pretty blockerish to me.
Target Milestone: Firefox 3 M10 → Firefox 3 Mx
Priority: -- → P5
What's left to do here?
Priority: P5 → P3
Target Milestone: Firefox 3 Mx → Firefox 3 M11
Replace the unlocalized, inaccessible calendar popup (when you search, then add a "Visited" condition) with datetimepicker.xml, and remove the one in places.xml. Roughly speaking, "everything."
Target Milestone: Firefox 3 beta3 → ---
Priority: P3 → P4
Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Depends on: 422977
Depends on: 436380
no reasons to still have that code, it is unused, it is old and bitrotted.
And we are moving toward different views for 3.7 and 4.0.
So, i'm going to do some cleanup.
Assignee: mano → mak77
Summary: Remove the places-specific calendar widget → Remove unused places calendar widget and advanced query builder code
Blocks: 399755
Attached patch remove old unused code (obsolete) — Splinter Review
This removes a bunch of unused code, entities and such

Asking review to dietrich for Places part, Dao for browser part (mostly style changes, notice this patch includes bug 399755 to get rid of Bookmarks-folder.png).
Attachment #252532 - Attachment is obsolete: true
Attachment #406025 - Flags: review?(dietrich)
Attachment #406025 - Flags: review?(dao)
Attachment #406025 - Flags: review?(dao) → review-
Comment on attachment 406025 [details] [diff] [review]
remove old unused code

>--- a/browser/themes/winstripe/browser/browser-aero.css
>+++ b/browser/themes/winstripe/browser/browser-aero.css

>+#wrapper-personal-bookmarks[place="palette"] > .toolbarpaletteitem-box {
>+  background: url("chrome://browser/skin/places/bookmarksToolbar-aero.png") no-repeat;
>+}

This can't possibly work.
heh that actually works! we can make it better still
wo, i misread that!
Attached patch patch v1.1Splinter Review
fixed dao's comment
Attachment #406025 - Attachment is obsolete: true
Attachment #406031 - Flags: review?(dao)
Attachment #406025 - Flags: review?(dietrich)
Attachment #406031 - Flags: review?(dietrich)
Comment on attachment 406031 [details] [diff] [review]
patch v1.1

r=me
Attachment #406031 - Flags: review?(dietrich) → review+
Attachment #406031 - Flags: review?(dao) → review+
thanks!
http://hg.mozilla.org/mozilla-central/rev/ae6c0b1a2dce
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: