367991 - Remove unused places calendar widget and advanced query builder code

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Asaf Romano (gone)]

Remove the places-specific calendar widget.

Right now, it's only used by advanced-search UI which is kinda broken already. We can use the shared calendar widget (bug 92174) if we ever make this UI work again.

Comment 1

[Asaf Romano (gone)]

Attachment: remove it

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 252532 [details] [diff] [review]
remove it

r=sspitzer

Comment 3

[Kenneth Herron]

Comment on attachment 252532 [details] [diff] [review]
remove it

Patch checked in.

Comment 4

[Asaf Romano (gone)]

[e-mail]: Please back this out (and please, don't checkin my patches), I didn't check this in yet because it breaks the current advanced search UI.

Comment 5

[Kenneth Herron]

Backed out. If you didn't want it checked in, then why was the "[checkin needed]" status set?

Comment 6

[Mike Connor [:mconnor]]

Mano, can this reland, or do we still have the same issue?

Comment 7

[Mike Connor [:mconnor]]

Missing the freeze, moving out.

Comment 8

[Dietrich Ayala (:dietrich)]

doesn't need to block beta. not sure why it's a blocker. what do you plan on replacing the widget with?

Comment 9

[Phil Ringnalda (:philor)]

datetimepicker.xml - localized via toLocaleFormat(), accessible (both in terms of html:role and keyboard access).
places.xml - localized via "// localized stuff, FIXME: move somewhere else" and en-US strings hardcoded in the binding, no sign of even an "// a11y - make someone else add some later" comment

Other than the obscurity of the feature, sounds pretty blockerish to me.

Comment 10

[Mike Connor [:mconnor]]

What's left to do here?

Comment 11

[Phil Ringnalda (:philor)]

Replace the unlocalized, inaccessible calendar popup (when you search, then add a "Visited" condition) with datetimepicker.xml, and remove the one in places.xml. Roughly speaking, "everything."

Comment 12

[Mike Connor [:mconnor]]

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

Comment 13

[Marco Bonardo [:mak]]

no reasons to still have that code, it is unused, it is old and bitrotted.
And we are moving toward different views for 3.7 and 4.0.
So, i'm going to do some cleanup.

Comment 14

[Marco Bonardo [:mak]]

Attachment: remove old unused code

This removes a bunch of unused code, entities and such

Asking review to dietrich for Places part, Dao for browser part (mostly style changes, notice this patch includes bug 399755 to get rid of Bookmarks-folder.png).

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 406025 [details] [diff] [review]
remove old unused code

>--- a/browser/themes/winstripe/browser/browser-aero.css
>+++ b/browser/themes/winstripe/browser/browser-aero.css

>+#wrapper-personal-bookmarks[place="palette"] > .toolbarpaletteitem-box {
>+  background: url("chrome://browser/skin/places/bookmarksToolbar-aero.png") no-repeat;
>+}

This can't possibly work.

Comment 16

[Marco Bonardo [:mak]]

heh that actually works! we can make it better still

Comment 17

[Marco Bonardo [:mak]]

wo, i misread that!

Comment 18

[Marco Bonardo [:mak]]

Attachment: patch v1.1

fixed dao's comment

Comment 19

[Dietrich Ayala (:dietrich)]

Comment on attachment 406031 [details] [diff] [review]
patch v1.1

r=me

Comment 20

[Marco Bonardo [:mak]]

thanks!
http://hg.mozilla.org/mozilla-central/rev/ae6c0b1a2dce

Comment 21

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv