399755 - fix "Bookmarks Toolbar Items" icon in the customization palette, get rid of Bookmarks-folder.png

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Phil Ringnalda (:philor)]

STR:
1. Open toolbar customization
2. Drag the "Bookmarks Toolbar Items" item into the palette
3. Notice that it doesn't have an icon

In Winstripe, this is a Places regression - the original Places ifdefs in browser/themes/winstripe/browser/jar.mn mistakenly put skin/classic/browser/Bookmarks-folder.png into the #else, instead of the both-Places-and-not part, so bug 386392 wound up completely dropping it from ever being jarred up.

In Pinstripe, it's ancient utter failure: bug 235300 changed browser.css to use "#wrapper-personal-bookmarks .toolbarpaletteitem-box" as a selector, rather than the failing ".toolbarpaletteitem-box[type="bookmarks-toolbar"][place="palette"]", but either it didn't ever land in Pinstripe, or it landed and then got clobbered by some move or other. In either case, the image that Pinstripe tries to apply with a failing selector, chrome://browser/skin/bookmarks/Toolbar-bookmarks.png, does not exist, and hasn't back at least as far as the Aviary branch.

Comment 1

[Marco Bonardo [:mak]]

well actually it exists in winstripe

http://mxr.mozilla.org/mozilla-central/search?string=Bookmarks-folder.png

but it's completely useless (white page)

i think we should get rid of it and just use

http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/places/bookmarksToolbar.png

so we get rid of a useless image, we use a more meaningful image and we fix bogus css in pinstripe (looks like gnomestripe does not have an icon defined)

Comment 2

[Marco Bonardo [:mak]]

i could fix this in bug 367991 while cleaning up.

Comment 3

[Marco Bonardo [:mak]]

fixed along with bug 367991

Comment 4

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv