368264 - Various components missing from win32 installer builds (chardet.dll, universalchardet.dll) -- no auto-detect character encoding

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

Bug 361437 switched the installer to use local GRE by default.  With local GRE, various things are missing after installation.  Specifically, chardet.dll and unversalchardet.dll, probably others.  The symptom people seem to notice is that the "auto-detect" character encoding menu item is missing.

The reason for the bustage is that browser.jst deletes the files after they get installed.  The upgradeCleanup first deletes files it thinks are not part of the GRE and then files that are part of the GRE /if/ the GRE was not installed locally.  Unforunately, the lists are wrong.  chardet.dll and universalchardet.dll (among others) are both in the non-GRE list.

To fix this, either
1. Identify all files that are part of the GRE (see mozilla/embedding/config/)
2. Move those files from the non-GRE list to the GRE list.
or
Switch back to non-local GRE.

Comment 1

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Neil, can I have your r and sr to back out BenoitRen's patch?  And KaiRo's approval?  Non-local GRE got much more testing than local.

Comment 2

[[e-mail]]

Attachment: Proposed patch

By saving the installer files locally and removing the call to upgradeCleanup I was able to verify that only these two files are affected.

Comment 3

[Robert Kaiser]

Nice. I'd much more prefer if we are able to solve this with keeping locale GRE in place.

Comment 4

[Andrew Schultz]

Comment on attachment 252897 [details] [diff] [review]
Proposed patch

right.  I just verified that all the other files from gre.xpi were not deleted.

Comment 5

[[e-mail]]

Fix checked in to the trunk, but leaving on the radar for the branch.

Comment 6

[[e-mail]]

Attachment: Branch patch

Branch really doesn't want chardet.dll but it wants universalchardet.dll (View/Character Coding/Auto-Detect/Universal).

Comment 7

[Robert Kaiser]

Comment on attachment 253032 [details] [diff] [review]
Branch patch

a=me for 1.1.1 (given it gets r+)

Comment 8

[Andrew Schultz]

Comment on attachment 253032 [details] [diff] [review]
Branch patch

r=me
(note that packager/build/ is super-obsolete)

Comment 9

[[e-mail]]

Fixed on the branch too.