369588 - switch all thunderbird and lightning tinderboxes to cairo

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Now that bug 177805 has landed, non-cairo builds are no longer supported.

Some Thunderbird and Lightning release tinderboxes are still forcibly building non-cairo.  (Also Sunbird, but they're currently building from a branch.)

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Some of the comments suggest that this might not work on some of the machines.

Comment 2

[Matthew (lilmatt) Willis]

For Sunbird and Lightning, please wait until after 0.3.1 releases (hopefully early next week) before applying dbaron's patch.  At that point we should be able to also move the Sb-Trunk tinders to cairo as well.

Comment 3

[Matthew (lilmatt) Willis]

(In reply to comment #2)
I didn't realize this bug was to fix the Lightning trunk tbox bustage. (thanks
Ted)

In that case, this patch is okay to apply to the Lightning trunk tboxes. 
Please leave Sunbird (which isn't in dbaron's patch) alone until after 0.3.1.

galactica may still need pango (and perhaps gcc) to be updated (see bug 332900
and bug 356663) before this will work, and since doing that would possibly
affect the Sunbird build as well, if galactica stays red after applying, it'll
need to wait until after we ship 0.3.1 to be fixed.

Comment 4

[Scott MacGregor]

bumping the severity on this since this is keeping us from getting nightly Thunderbird trunk builds on windows and linux. 

dbaron, do you have suggestions on what we need to do with the config patch attached to this bug? You mentioned that there are some comments that these config changes may not work on some of the build machines. Are these issues with the build machine or the apps that the build machine is building? 

I know for Thunderbird on windows, I don't have:

-ac_add_options --enable-default-toolkit=windows

defined in my debug and static builds seem to build and run ok.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

This could probably just be checked in, but it might not fix some of the tinderboxes -- especially the ones where I'm removing comments explaining why it's not going to work.

Comment 6

[Scott MacGregor]

Comment on attachment 254281 [details] [diff] [review]
patch

Paul can you or one of the build folks review this?

This should fix the tinderbox redness for windows, and possibly linux on some of the build machines. 

The linux builds may still be red based on comment 3 where pango and gtk2 may need upgraded but I see there is already a separate bug for that.

Comment 7

[J. Paul Reed [:preed]]

Comment on attachment 254281 [details] [diff] [review]
patch

Can't hurt. :-) r=preed

Comment 8

[Scott MacGregor]

I landed the Thunderbird config changes to see if this would make things better after Paul's review and sure enough as dbaron/lillmatt predicted the linux machine needs an upgraded version of pango:

checking for pango >= 1.6.0 pangoft2 >= 1.6.0 pangoxft >= 1.6.0... Requested 'pango >= 1.6.0' but version of Pango is 1.1.1

configure: error: Library requirements (pango >= 1.6.0 pangoft2 >= 1.6.0 pangoxft >= 1.6.0) not met; consider adjusting the PKG_CONFIG_PATH environment variable if your libraries are in a nonstandard prefix so pkg-config can find them.
*** Fix above errors and then restart with "gmake -f client.mk build"

I've spun up Bug 369874 for this.

Comment 9

[Simon Paquet [:sipaq]]

Now that Sunbird 0.3.1 has been released, there's nothing blocking this from the Calendar side of things.

Comment 10

[Phil Ringnalda (:philor)]

And, at various times (mostly as part of the 2007-02-21 reversion to the trunk, and in coop's 2007-03-22 mozconfig cleanup), it's all been done.