Open Bug 37057 Opened 20 years ago Updated 5 years ago

X selection is not exported to the X cut buffer

Categories

(Core :: Selection, defect, P3, trivial)

x86
Linux
defect

Tracking

()

People

(Reporter: cks+mozilla, Unassigned)

References

Details

(Keywords: helpwanted, Whiteboard: patch checked in. new code ifdef'd out. discussion needed)

Attachments

(1 file)

Mozilla (recent nightly builds/CVS pull) automatically exposes the Mozilla
selection as the X selection (so if you highlight some text in Mozilla, you
can immediately paste it elsewhere) but doesn't export this current selection
into the (older) X cut buffer.

 Possibly there are internationalization issues that preclude exporting
things to the X cut buffer (I believe it only deals in ASCII, although
it will likely handle UTF-8 Unicode).
assiging to akkana for review
Status: UNCONFIRMED → NEW
Ever confirmed: true
honest -- assigning it to akkana
Assignee: mjudge → akkana
we don't currently put data in to SECONDARY, but it would be pretty easy to
add... I think I have a bug on this, but I can't find it.  I don't really plan
on supporting CUT_BUFFER[0-7] unless there is real a real demand for it, and
even then I won't get a chance to get to it any time soon.
If you already have a bug on this, I'll send this one your way too, and let you
dup it.  Might be a good candidate for HELPWANTED ... in fact, I'll add that
now.
Assignee: akkana → pavlov
Keywords: helpwanted
Target Milestone: --- → M20
Mass-moving all M20-M30 XPToolkit bugs to Future
Target Milestone: M20 → Future
I've created a patch that exports the contents of the X selection to the X cut
buffer.  Right now it updates from the global clipboard (on edit/copy menu
item), not the selection clipboard (on text highlight), I'm not sure which
behavior makes more sense.

I'm not sure this is really desirable behavior (X cut buffers were obsoleted for
a reason :) so it is #ifdefed out by default.  Perhaps it can be changed to a
preference setting in the future.
Adding keyword patch.  Might be worth adding the code even if it's ifdefed out
by default, in case we decide we want it.
Keywords: patch
*SPAM*: Changing the QA contact of all open/resolved Selection bugs from 
elig@netscape.com to BlakeR1234@aol.com.  After the many great years of service 
Eli has given to Mozilla, it's time for him to move on; he has accepted a 
position at Eazel.  We'll be sad to see him go, and I'll do my best to fill his 
spot...
QA Contact: elig → BlakeR1234
I wrote a discussion on the subject of this bug in the article
news://news.mozilla.org/8o9928$5su3@secnews.netscape.com

There I explain why it is a good idea to export the selected text to the (0)
cutbuffer even though cutbuffers are supposedly "obsolete".
The other reason to export the selection to cut buffer 0 is that that allows the
following sequence of actions to actually do something useful:

1) select text in mozilla
2) quit mozilla
3) attempt to paste the text you had selected into some other application

Currently, that has the weird result of pasting something that was selected in a
different app before he selection was made in Mozilla.
Adding Review keyword..this has been sitting around for a while now.
Keywords: review
I like the idea of having our X selection behaviour be closer to xterm's (and
4.x's?) behaviour.  I'll take a look at the patch soon.
*** Bug 75224 has been marked as a duplicate of this bug. ***
Whiteboard: r=pavlov, needs sr=, a=
Target Milestone: Future → mozilla0.9.2
+  // Make sure we have a transferable:
+  if (!transferable) {
+    g_print("Clipboard has no transferable!\n");
+    return;
+  }

Please remove that or at least make it an NS_WARNING()

Fix that and you have an sr=blizzard.
Whiteboard: r=pavlov, needs sr=, a= → r=pavlov, sr=blizzard, need a=
Blocks: 83989
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
Whiteboard: r=pavlov, sr=blizzard, need a= → r=pavlov, sr=blizzard, a=asa
Checked in patch r=pavlov, sr=blizzard, a=asa.

So i'm not sure what to do with this bug.. i've checked in the patch, but since 
the ifdef is off, we still don't export to the X cut buffer.  Should we leave 
this open for discussion about turning it on or should we file a new bug?
Whiteboard: r=pavlov, sr=blizzard, a=asa → patch checked in. new code ifdef'd out. discussion needed
Target Milestone: mozilla0.9.2 → mozilla0.9.3
-> 0.9.4 per Pavlov
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Target Milestone: mozilla0.9.4 → mozilla0.9.5
.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Target Milestone: mozilla0.9.6 → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.2
changing selection qa to tpreston.
QA Contact: blaker → tpreston
I haven't tested this yet (too many tabs open), but it would be nice to be able
to copy by select, close mozilla, and then be able to paste it into another app.
Assignee: pavlov → nobody
QA Contact: tpreston → selection
Target Milestone: mozilla1.2alpha → ---
You need to log in before you can comment on or make changes to this bug.