373350 - Days in minimonth should not be shrinked to one character

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Thorsten 'nightrat' Fritz]

In german, the days in minimonth are displayed "Mo" "Di" "Mi "Do" "F" "Sa" "So".

Only Friday has one character, so this should be changed so that all days have two characters.

Comment 1

[Stefan Sitter [:ssitter]]

Confirmed.

After Bug 317607 being fixed the abbreviations for the day names are now retrieved from localization language and not calculated from the full OS day names.

Currently also the abbreviations from localization will be shorten automatically: http://lxr.mozilla.org/mozilla1.8/source/calendar/resources/content/datetimepickers/minimonth.xml#217

This should not be done as it will result in unwanted or uncommon abbreviations. For example in German the minimonth header should be "Mo Di Mi Do Fr Sa So" and not "Mo Di Mi Do F Sa So".

Comment 2

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Removed "retrieve day names from OS" and "shrinking of day names" parts.

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 259215 [details] [diff] [review]
Patch v1

Better patch in preparation.

Comment 4

[Martin Schröder [:mschroeder]]

Attachment: Patch v2

Removed "retrieve day names from OS", "shrinking of day names" parts and combined for-loops.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 259222 [details] [diff] [review]
Patch v2

The fallback to get the dates from the OS should not be removed. It might be needed if somebody tries to use the datepicker outside calendar.
You could set a bool when you needed to use the fallback, and later only shrink when the bool is set.

Comment 6

[Martin Schröder [:mschroeder]]

Attachment: Patch v3

Shrinking of day names only if fallback to OS format.

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 262133 [details] [diff] [review]
Patch v3

r=mvl

Comment 8

[Stefan Sitter [:ssitter]]

Doesn't this patch conflict with the patch in Bug 364672?

Comment 9

[Martin Schröder [:mschroeder]]

Attachment: Merged patch

Merged patch for the conflicting patches from bug 373350 (this one) and 364672.

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Checked in merged patch on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 11

[Pete Riley]

Attachment: Screenshot

Some of the day names in my minimonth are still one character (see screenshot).

U.S. English
Lightning 0.7pre 2007080305

Comment 12

[Stefan Sitter [:ssitter]]

(In reply to comment #11)
> Some of the day names in my minimonth are still one character

Because they are specified as one character only -> everything is OK
http://lxr.mozilla.org/mozilla/source/calendar/locales/en-US/chrome/calendar/dateFormat.properties#83