37480 - mozilla does not persist attribute values to localstore.rdf

Status: VERIFIED WORKSFORME

(Core :: XUL, defect, P3)

Description

[Tom Everingham]

Overview Description:  Re-launching mozilla does not bring up main window
in its last state - size is always very small on my system.

Steps to Reproduce:
1.)  Launch application

Expected Results:  Should remember last size

Build Date & Platform Bug Found:  NT 2000042709

Additional Builds and Platforms Tested On:  works on linux

Comment 1

[troy]

Changing component to browser

Comment 2

[Sean Richardson]

Odd, I tried this with the same build on WinNT, in the -talkback.zip version, 
and it worked for me.

Steps to Reproduce:
1. Launch Mozilla; Remember that window size.
2. Change the window size to anything distinctly different; remember this size 
   too.
3. Exit Mozilla.
4. Restart Mozilla, compare window size to those seen is steps 1 and 2.

My expected and actual window sizes for step 4 are both the same as step 2.

If there is a problem here, it would be a regression of the fix for bug 16516,
"[DOGFOOD] view sidebar not persistent on subsequent windows", by way of
bug 12575, "[DOGFOOD][FEATURE] Window size and position should be remembered", 
of, for the browser (although it's the same code remembering all window sizes),
bug 18422, "Not remembering browser window size", both DUPs of the 
first-mentioned bug.

[e-mail], are you restarting NT between Mozilla sessions?
Could your prefs be corrupted?

Anyone else seeing this problem?

Comment 3

[Asa Dotzler [:asa]]

this worksforme with mozilla bits from 4/27 under NT.

Comment 4

[Sean Richardson]

Forgot -- this might also be due to bug 15555, "popup browser window attributes 
should not persist to real browsers", nsbeta2, regression -- if you normally
have popup windows appear in each Mozilla session.

Comment 5

[Jesse Ruderman]

Bug 20847 says that mozilla doesn't remember whether it was maxmized or not.  
Tever, does this only apply to not remembering maximized state, or is it not 
remembering other sizes as well?

Comment 6

[Tom Everingham]

ok, this is only showing up on the commericial build for me - mozilla IS 
remembering it's last size.  What I am now noticing that the commercial
build seems to be using the last window size/position mozilla was set at. 
It doesn't remember it's own. 

sidr, I did a clean install and do not re-start NT between sessions.  

Comment 7

[Sean Richardson]

Cc-ing [e-mail], who fixed this in the Mozilla codebase;
passing to the XPApps component as this can't be triaged any further by
"external" testers.

Comment 8

[Sean Richardson]

Actually changing component - failed after fixing e-mail address typo.

Comment 9

[sairuh (rarely reading bugmail)]

over to jrgm --shouldn't this go to xptoolkit...?

Comment 10

[John Morrison]

Yeah. I am not seeing localstore.rdf be updated with *any* annotations [sidebar,
<window> persisted attributes, etc.] [win32 2000050111 commercial build]

The mozilla build works fine (persists values), and the commercial build
correctly reads in localstore.rdf at startup. (cc: danm for, uh, because).

Comment 11

[John Morrison]

This also does not work (persist) on the commercial mac and linux builds.
To be clear, it appears that nothing is persisted back to localstore.rdf.

Passing to danm, but waterson may have an answer (?). I'll check tomorrow's
commercial builds again for this problem.

Comment 12

[Chris Waterson]

This may be happening because nsXULDocument is leaking, cf. bug 37639. I'm
marking as a dependency: if it still happens after that bug is fixed, then I was
wrong.

Comment 13

[John Morrison]

Okay ... yesterday this appeared to be a commercial vs. mozilla 
build system problem. Today, it is mixed (comm vs. moz) + (OS type).

                   Comm.              Moz.
                20000502nn         20000502nn
-------------------------------------------------
macos 9          persists           persists
win32 95         persists             not
linux rh6.1        not                not

Comment 14

[John Morrison]

changing title from "mozilla does not 'remember' last main window size on 
relaunch" -- i.e., when it fails, no persisted attribute values are written
to localstore.rdf

  FROM bug #38077
   ---- Additional Comments From Chris Waterson 2000-05-03 14:13 -------

  I'm pretty sure this has to do with the fact that we're leaking the
  nsXULDocument since Ben checked in. We could move the call to Persist from the
  nsXULDocument's dtor over to the SetScriptGlobalObject() method, which should
  make this more robust.

Comment 15

[John Morrison]

*** Bug 38077 has been marked as a duplicate of this bug. ***

Comment 16

[John Morrison]

For completeness, today's results:

                  Comm.              Moz.
                20000503nn         20000503nn
-------------------------------------------------
macos 9            not              persists
win32 95         persists           persists
linux rh6.1        not                not

Comment 17

[Simon Fraser [no longer active]]

We seem to leak every XUL document, including the hidden window and the profile 
dialog, on Mac commercial build.

Comment 18

[John Morrison]

This works correctly again, as waterson predicted it would. 
Values are persisted for linux/mac/win32, comm. and mozilla builds for today.

Comment 19

[John Morrison]

verified.