Open Bug 376409 Opened 13 years ago Updated 12 years ago

send empty update snippets if AUS url schema url is version 1, but Fx version is not 1.5.0.x

Categories

(AUS Graveyard :: General, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

4.x (triaged)

People

(Reporter: moco, Assigned: morgamic)

Details

Attachments

(1 file)

send empty update snippes if AUS url schema url is version 1, but Fx version is not 1.5.0.x

This related to bug #360127, which is about doing this for url schema version 2 with fx version 1.5.

We are seeing this, and I think it is leading to bug #371649 bug #375710.

For example, see Lech's http headers in bug #371649 (https://bugzilla.mozilla.org/attachment.cgi?id=256385)

He is requesting:
 
https://aus2.mozilla.org/update/1/Firefox/2.0.0.2/2007021917/WINNT_x86-msvc/en-US/release/update.xml

that's should not be happening, and it indicates he has franken-fox.

in bug #371649 comment #15, marcia writes:

"By way of information, the users that are reporting this issue in Hendrix all seem to have the horked user agents noted in Bug 374140."

rob helmer and I looked over some aus apache logs and saw quite a few franken-fox aus urls that began with. "/update/1/Firefox/2.0"

As for how they are ending up with franken-fox, I'm not sure.

for this bug, I'm requesting that we:

1)  fix aus so that we return the empty snippet when we detect franken-fox, like we are doing in bug #360127.

And also:

2)  add logging to so we can keep track of the amount of franken-fox requests we get.  see bug #368578 for this issue.
3)  At some point, we might want to give franken-foxes complete mars, see bug #376407 for more on that.
Note, this might cause problems for CK-IBM builds, which can be of the form "/update/1/Firefox/2.0" but are not franken-fox.

it would mean they would not be getting any more updates.

mkaply, can I copy and paste your info about the CK-IBM builds here?
Summary: send empty update snippes if AUS url schema url is version 1, but Fx version is not 1.5.0.x → send empty update snippets if AUS url schema url is version 1, but Fx version is not 1.5.0.x
I don't mind if this happens. the 1/Firefox/2.0 syntax is my mistake that I'll fix on this end.

This definitely should produce an empty updates URL.
Simple patch to disallow updates for schema 1 URLs that are NOT 1.5.0.x
I'll bet this patch would break the update verification release scripts, which are incredibly lazy about schemas :)

Mike, do you know if there's a significant Frankenfox population still on 1.5.x or 2.x?
No, I don't.  We could pull a day's worth of numbers and see, though.  We basically want to look for:

1/Firefox/2.x

or

2/Firefox/1.x

Right?
(In reply to comment #5)
> No, I don't.  We could pull a day's worth of numbers and see, though.  We
> basically want to look for:
> 
> 1/Firefox/2.x
> 
> or
> 
> 2/Firefox/1.x
> 
> Right?
> 

I do believe so!
You need to log in before you can comment on or make changes to this bug.