376409 - send empty update snippets if AUS url schema url is version 1, but Fx version is not 1.5.0.x

Status: RESOLVED INCOMPLETE

(AUS Graveyard :: General, defect)

Description

[(not reading, please use [e-mail] instead)]

send empty update snippes if AUS url schema url is version 1, but Fx version is not 1.5.0.x

This related to bug #360127, which is about doing this for url schema version 2 with fx version 1.5.

We are seeing this, and I think it is leading to bug #371649 bug #375710.

For example, see Lech's http headers in bug #371649 (https://bugzilla.mozilla.org/attachment.cgi?id=256385)

He is requesting:
 
https://aus2.mozilla.org/update/1/Firefox/2.0.0.2/2007021917/WINNT_x86-msvc/en-US/release/update.xml

that's should not be happening, and it indicates he has franken-fox.

in bug #371649 comment #15, marcia writes:

"By way of information, the users that are reporting this issue in Hendrix all seem to have the horked user agents noted in Bug 374140."

rob helmer and I looked over some aus apache logs and saw quite a few franken-fox aus urls that began with. "/update/1/Firefox/2.0"

As for how they are ending up with franken-fox, I'm not sure.

for this bug, I'm requesting that we:

1)  fix aus so that we return the empty snippet when we detect franken-fox, like we are doing in bug #360127.

And also:

2)  add logging to so we can keep track of the amount of franken-fox requests we get.  see bug #368578 for this issue.
3)  At some point, we might want to give franken-foxes complete mars, see bug #376407 for more on that.

Comment 1

[(not reading, please use [e-mail] instead)]

Note, this might cause problems for CK-IBM builds, which can be of the form "/update/1/Firefox/2.0" but are not franken-fox.

it would mean they would not be getting any more updates.

mkaply, can I copy and paste your info about the CK-IBM builds here?

Comment 2

[Mike Kaply [:mkaply]]

I don't mind if this happens. the 1/Firefox/2.0 syntax is my mistake that I'll fix on this end.

This definitely should produce an empty updates URL.

Comment 3

[Michael Morgan [:morgamic]]

Attachment: v1, patch to not offer updates to other frankenfox case

Simple patch to disallow updates for schema 1 URLs that are NOT 1.5.0.x

Comment 4

[Robert Helmer [:rhelmer]]

I'll bet this patch would break the update verification release scripts, which are incredibly lazy about schemas :)

Mike, do you know if there's a significant Frankenfox population still on 1.5.x or 2.x?

Comment 5

[Michael Morgan [:morgamic]]

No, I don't.  We could pull a day's worth of numbers and see, though.  We basically want to look for:

1/Firefox/2.x

or

2/Firefox/1.x

Right?

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to comment #5)
> No, I don't.  We could pull a day's worth of numbers and see, though.  We
> basically want to look for:
> 
> 1/Firefox/2.x
> 
> or
> 
> 2/Firefox/1.x
> 
> Right?
> 

I do believe so!

Comment 7

[Takanori MATSUURA]

This bug lies at rest in the graveyard.