If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Bookmark toolbar folders don't auto-open on hover

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: mossop, Assigned: Josh Aas)

Tracking

({regression})

Trunk
x86
Mac OS X
regression
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
On other platforms, and on Bon Echo on Mac, when you open one folder on the bookmark toolbar, moving the mouse over other folders will auto-open them. This does not quite happen on current trunk.

1. Click on a bookmark toolbar folder to open it.
2. Move the mouse left or right to another folder.

The other folder should open, but it doesn't.

A couple of things to note: 

You can get the other folders to open automatically, but what you do is move the mouse over the opened menupopup, then move it straight onto the other folder toolbarbutton, at which point it will open.

On a places bookmark build the result is slightly different. You cannot get the other folders to open automatically, but moving the mouse over the other folders will at least highlight the toolbarbutton visually. I am unsure though if the places toolbar has the auto-open code for folders though.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a4pre) Gecko/20070407 Minefield/3.0a4pre ID:2007040704 [cairo]
(Reporter)

Comment 1

11 years ago
Interestingly bug 355102 appears to have made this worse. Now the trick of moving over the popup then onto the toolbarbutton no longer opens the other menus.

Comment 2

11 years ago
this works for josh... he's going to look at it further.
Flags: blocking1.9+
(Reporter)

Comment 3

11 years ago
I'd add that folders within folders on the toolbar do auto-open, it's just those on the toolbar that won't. Knowing how those work I'd guess that there's something odd about the mouseover events going to the main window while the menupopup is open.

Perhaps this is related to bug 371405?
(Assignee)

Comment 4

11 years ago
Created attachment 262608 [details] [diff] [review]
fix v1.0

This is a better way to do mouse move routing. This implementation mimics GTK2's behavior, fixing this bug.
Attachment #262608 - Flags: review?(stuart.morgan)
Blocks: 371405
Comment on attachment 262608 [details] [diff] [review]
fix v1.0

Looks good. r=cbarrett
Attachment #262608 - Flags: review?(stuart.morgan) → review+
(Assignee)

Updated

11 years ago
Attachment #262608 - Flags: superreview?(roc)
(Assignee)

Updated

11 years ago
Attachment #262608 - Flags: superreview?(roc) → superreview?(jonas)
Comment on attachment 262608 [details] [diff] [review]
fix v1.0

rsr=sicking. Would be great if you could get a proper sr when vlad or stuart gets back.
Attachment #262608 - Flags: superreview?(jonas) → superreview+
(Assignee)

Comment 7

11 years ago
Comment on attachment 262608 [details] [diff] [review]
fix v1.0

Requesting another review from pav for when he gets back.
Attachment #262608 - Flags: review?(pavlov)
(Assignee)

Comment 8

11 years ago
fixed on trunk
Blocks: 354768, 377105
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
No longer blocks: 354768
(Assignee)

Updated

11 years ago
Blocks: 354768, 378316
Blocks: 362616

Updated

10 years ago
Attachment #262608 - Flags: review?(pavlov)
You need to log in before you can comment on or make changes to this bug.