The default bug view has changed. See this FAQ.

output mediatype patch won't work on branches

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: aaronr, Assigned: aaronr)

Tracking

({fixed1.8.0.12, fixed1.8.1.4})

Trunk
x86
All
fixed1.8.0.12, fixed1.8.1.4

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

4.31 KB, patch
surkov
: review+
Details | Diff | Splinter Review
(Assignee)

Description

10 years ago
Created attachment 261039 [details] [diff] [review]
patch

The current code we have to implement output mediatype in the trunk won't work on the branches.  Per comment in bug 376817, we probably shouldn't change the anonymous content's DOM while the XBL is attaching which is what we are currently doing for output with mediatype.

Testcase to verify the fix is listed in URL and here: https://bugzilla.mozilla.org/attachment.cgi?id=232362

This patch uses a setTimeout call to set the value of the underlying anonymous content.
Attachment #261039 - Flags: review?(surkov.alexander)
(Assignee)

Updated

10 years ago
Attachment #261039 - Flags: review?(doronr)

Comment 1

10 years ago
Comment on attachment 261039 [details] [diff] [review]
patch

>+              // FF 1.5 or FF 2.  Wo we'll wait a tick before changing it here.

s/Wo/So when you check in please :)
Attachment #261039 - Flags: review?(doronr) → review+
(Assignee)

Comment 2

10 years ago
Created attachment 261054 [details] [diff] [review]
patch2

fixes Doron's nit
Attachment #261039 - Attachment is obsolete: true
Attachment #261054 - Flags: review?(surkov.alexander)
Attachment #261039 - Flags: review?(surkov.alexander)

Updated

10 years ago
Attachment #261054 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

10 years ago
checked into trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
(Assignee)

Comment 4

10 years ago
checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16
Keywords: fixed1.8.0.12, fixed1.8.1.4
Whiteboard: xf-to-branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.