377225 - [10.3] Horizontal scrollbars (and others) draw improperly (no arrows, incomplete well)

Status: RESOLVED INVALID

(Core :: Widget: Cocoa, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: simple testcase

Since scrollbars switched to themed, horizontal scrollbars don't draw properly.

1. There are no arrows
2. The well is not drawn completely (too short/incomplete; in the screenshot, notice the top edge of the well on the left ends before the thumb ends)

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: screenshot

Comment 2

[Colin Barrett [:cbarrett]]

I can't reproduce this in Firefox. Can you please test and make sure you can reproduce it there? In the future, a bug like this should be filed in Camino until it can be reproduced in Firefox, then move it to Core.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Yes, it happens in Firefox, too.  Today's nightly, fresh profile.

Comment 4

[Stuart Morgan]

I don't see it in a fresh trunk Camino build. 10.3 specific, maybe?

Comment 5

[philippe (part-time)]

I can only see it with on 10.3.9 with the latest FX build. 10.4.9 ppc is ok here.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Just to make Colin even angrier at 10.3, I don't see *any* scrollbars anywhere in my debug build, and see nothing useful logged to the Console :(

Comment 7

[philippe (part-time)]

Attachment: test case - 2

absolute positioned with overflow: scroll

On 10.3.9, both the horizontal and vertical scroll bar is incorrectly painted.

Comment 8

[philippe (part-time)]

Attachment: screen shot for test case - 2

Comment 9

[Colin Barrett [:cbarrett]]

Can you guys try setting SCROLLBARS_VISUAL_DEBUG (in nsNativeThemeCocoa.mm) and give me screen shots of what the test cases produce?

Comment 10

[philippe (part-time)]

Attachment: screenshot, test case2 - 10.3.9

Fresh ColourFox build :-) SCROLLBARS_VISUAL_DEBUG set to 1 (that is correct, right ?).
build with gcc4.01/10.3.9sdk

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Some data:

1) I do get scrollbars when I do a static/opt build (yay!)  

1a) There are no errors when compiling nsNativeThemeCocoa.mm in debug; my buffer isn't big enough to tell on static/opt and I wasn't paying attention during that build.

2) When we switch to "both arrows at one side", the two "blank" spaces in the well collapse down to only having one blank space.

3) When philippe compiles with gcc4.01/10.3.9sdk, he gains an arrow on the vertical scrollbar on his testcase compared to an official build (gcc3.3/10.3.9sdk)

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Testcase 1 with visual debug; one arrow at each end

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Testcase 1 with visual debug; arrows together

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Testcase 2 with visual debug; one arrow at each end

This shows the same things as attachment 261446 [details]: screen shot for test case - 2, except with visual debug on; compare either this or that to attachment 261458 [details]: screenshot, test case2 - 10.3.9 (which philippe made with gcc4) and see how he gained one of the missing vertical arrows by switching compiler versions :p)

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Testcase 2 with visual debug; arrows together

Comment 16

[philippe (part-time)]

(In reply to comment #11)

> 3) When philippe compiles with gcc4.01/10.3.9sdk, he gains an arrow on the
> vertical scrollbar on his testcase compared to an official build
> (gcc3.3/10.3.9sdk)
> 
It is a bit more complicated. With the Minefield build with SCROLLBARS_VISUAL_DEBUG, when I hover over the vertical scrollbar, then the bottom arrow pops up.
But the same trick doesn't work for the horizontal scrollbar.
I can't reproduce that with the standard Minefield (id:2007041319)/Camino(id:2007041302) builds.

Comment 17

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: funky minefield select

Colin had me testing some other stuff for him on my slow ;) Mac and I ran across this example of broken vertical scrollbars.  Drop down any select, or at leas the Component one in a Core bug....

Comment 18

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: funky minefield select, arrows together

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

At some point recently something's changed so that now the horizontal scrollbar is drawing grey (i.e., as if it were in a bg window), at least in Camino.

Comment 20

[Colin Barrett [:cbarrett]]

Can you find a regression range? I really need to get a 10.3 machine to debug this, I'm a bit worried.

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The broken-scrollbars-appear-disabled thing began between 2007-05-09-06 and 2007-05-10-06 (Camino) builds (but it appears in current Minefields as well): http://tinyurl.com/2wvagy

The only thing that really jumps out at me in that list is josh in bug 380056.

On a "even more scrollbars can be broken" note, I also noticed while regression-hunting that the scrollbar in the CC box on bugs suffers from these problems, too (bad painting since themed scrollbars landed, and this disabled thing since it appeared).

Comment 22

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: screenshot of Testcase 1, now with the "disabled bug"

Here's how the testcase in comment 0 looks now with this "disabled bug."

Comment 23

[Colin Barrett [:cbarrett]]

Fixed by bug 385221

Comment 24

[Stefan [:stefanh]]

(In reply to comment #23)
> Fixed by bug 385221
> 

So... how was this fixed? By not supporting 10.3.9? Wouldn't a better resolution be "Invalid"?