Closed
Bug 377992
Opened 18 years ago
Closed 18 years ago
dbus build fails with some dbus versions
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wolfiR, Assigned: ted)
References
Details
Attachments
(3 files, 1 obsolete file)
764 bytes,
patch
|
Details | Diff | Splinter Review | |
975 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
921 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
since bug #377843 enabled the build of the dbus component we have two tinderboxen which are failing now:
nsDBusService.cpp:107: error: `DBUS_INTERFACE_LOCAL' was not declared in this scope
Both are running CentOS 4.3 so I guess it's the dbus version there which is too old. I found that DBUS_INTERFACE_LOCAL was previously named DBUS_INTERFACE_ORG_FREEDESKTOP_LOCAL
As I don't have a test system with an old dbus I can't really test locally if just handling this case would fix the build completely.
Therefore I wonder if we want to check for a minimal dbus version or trying to get it to work with older dbusses?
Reporter | ||
Comment 1•18 years ago
|
||
This should handle the special error we see currently but I don't know if it's enough and really correct.
Reporter | ||
Updated•18 years ago
|
Summary: dbus build fails iwith some dbus versions → dbus build fails with some dbus versions
Reporter | ||
Comment 2•18 years ago
|
||
Cent OS 4.3 seems to have dbus 0.22 which explains the changed define.
How about changing configure to only enable dbus if some minimum version is defined? Whatever dbus shipped with SUSE 10.1, say.
Reporter | ||
Comment 4•18 years ago
|
||
This sets the minimal dbus-glib version to 0.60 which is known to work.
BTW: I guess that's not the right component but I had a hard time to find the correct one.
Reporter | ||
Comment 5•18 years ago
|
||
sorry, the last one had an unrelated hunk in it
Attachment #262106 -
Attachment is obsolete: true
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 262107 [details] [diff] [review]
minimal version for dbus #2
Let's fix some bustage.
Attachment #262107 -
Flags: review+
Reporter | ||
Comment 7•18 years ago
|
||
checked in the version requirement:
Checking in configure.in;
/cvsroot/mozilla/configure.in,v <-- configure.in
new revision: 1.1795; previous revision: 1.1794
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•18 years ago
|
||
Per bsmedberg, we're going to change this to disable dbus by default, since our trunk linux tinderboxen don't have the right requirements. Our official policy is to make configure produce the same build as our official builds by default. We can re-enable dbus by default once the linux ref platform gets upped to a more modern system.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•18 years ago
|
Status: REOPENED → NEW
Component: XULRunner → Build Config
Product: Toolkit → Core
QA Contact: xulrunner → build-config
Blocks: 377843
Updated•18 years ago
|
Flags: in-testsuite-
Comment 9•18 years ago
|
||
My builds crash about every second time on shutdown
27329: assertion failed "!_dbus_transport_get_is_connected (connection->transport)" file "dbus-connection.c" line 1797 function _dbus_connection_last_unref
Assignee | ||
Comment 10•18 years ago
|
||
Off-by-default patch.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #262750 -
Flags: review?(benjamin)
Comment 11•18 years ago
|
||
Comment on attachment 262750 [details] [diff] [review]
disable dbus by default, add --enable-dbus configure arg
Yeah, this sucks but it will have to do until we have an uber-new linux refplatform.
Attachment #262750 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 12•18 years ago
|
||
Comment on attachment 262750 [details] [diff] [review]
disable dbus by default, add --enable-dbus configure arg
Checked in in trunk.
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•