377992 - dbus build fails with some dbus versions

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

since bug #377843 enabled the build of the dbus component we have two tinderboxen which are failing now:

nsDBusService.cpp:107: error: `DBUS_INTERFACE_LOCAL' was not declared in this scope

Both are running CentOS 4.3 so I guess it's the dbus version there which is too old. I found that DBUS_INTERFACE_LOCAL was previously named DBUS_INTERFACE_ORG_FREEDESKTOP_LOCAL

As I don't have a test system with an old dbus I can't really test locally if just handling this case would fix the build completely.
Therefore I wonder if we want to check for a minimal dbus version or trying to get it to work with older dbusses?

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: possible patch

This should handle the special error we see currently but I don't know if it's enough and really correct.

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

Cent OS 4.3 seems to have dbus 0.22 which explains the changed define.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

How about changing configure to only enable dbus if some minimum version is defined? Whatever dbus shipped with SUSE 10.1, say.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Attachment: minimal version for dbus

This sets the minimal dbus-glib version to 0.60 which is known to work.

BTW: I guess that's not the right component but I had a hard time to find the correct one.

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

Attachment: minimal version for dbus #2

sorry, the last one had an unrelated hunk in it

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 262107 [details] [diff] [review]
minimal version for dbus #2

Let's fix some bustage.

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

checked in the version requirement:
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1795; previous revision: 1.1794
done

Comment 8

[(not currently active) Ted Mielczarek]

Per bsmedberg, we're going to change this to disable dbus by default, since our trunk linux tinderboxen don't have the right requirements.  Our official policy is to make configure produce the same build as our official builds by default.  We can re-enable dbus by default once the linux ref platform gets upped to a more modern system.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

My builds crash about every second time on shutdown
27329: assertion failed "!_dbus_transport_get_is_connected (connection->transport)" file "dbus-connection.c" line 1797 function _dbus_connection_last_unref

Comment 10

[(not currently active) Ted Mielczarek]

Attachment: disable dbus by default, add --enable-dbus configure arg

Off-by-default patch.

Comment 11

[Benjamin Smedberg]

Comment on attachment 262750 [details] [diff] [review]
disable dbus by default, add --enable-dbus configure arg

Yeah, this sucks but it will have to do until we have an uber-new linux refplatform.

Comment 12

[(not currently active) Ted Mielczarek]

Comment on attachment 262750 [details] [diff] [review]
disable dbus by default, add --enable-dbus configure arg

Checked in in trunk.