Closed Bug 388743 Opened 17 years ago Closed 17 years ago

build dbus on linux by default (--enable-dbus) to auto-detect online/offline state


(Firefox Build System :: General, defect)

Not set


(Not tracked)



(Reporter: steffen.wilberg, Assigned: steffen.wilberg)




(1 file, 1 obsolete file)

Bug 312793 introduced support for dbus online/offline events. Firefox and Thunderbird automatically toggle their state when they receive such an event.
This works fine on windows trunk, but on linux, you need to specify --enable-dbus in the mozconfig due to bug 377992.

Since the new linux reference platform has been introduced, we should build dbus by default and only disable it on the old tinderboxen specifically which don't meet its requirements.

This should be done by changing the --enable-dbus switch in
Another option would be to add --enable-dbus to the mozconfig of the linux tinderboxen:
As I said in bug 377992 comment 8, we want builds to match our official nightlies unless features are explicitly disabled.  This means that to do this right, the --enable-dbus switch should become a --disable-dbus switch, and the check for dbus should error if it is not found.

I'm not sure if all the trunk Linux tinderboxen have been updated though, or just Firefox.  preed, can you comment on this?
I know they have not... but we could turn this on for just Firefox right now.

That might be useful to get some testing, and then as we upgrade the other images, they'll know it'll "just work" (or... y'know... *should* "just work" ;-)
All of the tinderboxen have been migrated, including Thunderbird and Seamonkey, haven't they? So we could enable dbus now for every app, I guess.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → steffen.wilberg
Attachment #289210 - Flags: review?(benjamin)
Comment on attachment 289210 [details] [diff] [review]

r=me with a slight change.  Change MOZ_ENABLE_DBUS=force to be MOZ_ENABLE_DBUS=1 and remove the whole if block around the AC_MSG_ERROR below, so that we always error out if MOZ_ENABLE_DBUS is set but the library doesn't exist.
Attachment #289210 - Flags: review?(benjamin) → review+
Attached patch patch v2Splinter Review
Attachment #289210 - Attachment is obsolete: true
Attachment #289248 - Flags: review?(ted.mielczarek)
Comment on attachment 289248 [details] [diff] [review]
patch v2

We'll have to make sure that when this gets checked in, any tinderboxes that don't have the required version of dbus get --disable-dbus in their mozconfigs.
Attachment #289248 - Flags: review?(ted.mielczarek) → review+
Attachment #289248 - Flags: approval1.9?
Attachment #289248 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in;
/cvsroot/mozilla/,v  <--
new revision: 1.1890; previous revision: 1.1889

I'll fix any mozconfigs for tinderboxen that break for those that are in CVS.
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Depends on: 454391
No longer blocks: 697382
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.