378361 - Can't add RSS feeds caused by localization of rss.hostName

Status: RESOLVED FIXED

(Mozilla Localizations :: ko / Korean, defect)

Description

[Channy Yun [:channy]]

The rss.hostName must not be localized. It caused not to add RSS feeds in Thunderbird ko 2.0.0.0 pre version.

It must be fixed in Tb 2.0.0.1. And there are some message changes to be clear RSS subscription.

Comment 1

[Channy Yun [:channy]]

Attachment: am-newsblog.dtd.patch

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 262422 [details] [diff] [review]
am-newsblog.dtd.patch

If rss.hostName must not be localized, this sounds like a bug in the calling code.

I'd need further explanation why this fixes something.

Comment 3

[Channy Yun [:channy]]

There was a problem to make a RSS folder or add new feed if rss.hostName was localized into 2 byte code charaters such as Chinese, Japanese and Korean.

It was firstly reported in http://www.mozilla-japan.org/jp/l10n/faq/help.html#rss_account_foldername_garbled if you can read japanese.

I didn't find that because my profile was very old in version 1.0. But, I found it the latest litmus test of Tb 2.0 ko version.

Comment 4

[Channy Yun [:channy]]

In my investigation, &rss.hostName; is used in unique host name of incoming server - http://lxr.mozilla.org/mozilla1.8/source/mail/extensions/newsblog/rss.rdf

If there is no problem in source code, it must be marked "Do not localize" in http://lxr.mozilla.org/mozilla1.8/source/mail/locales/en-US/chrome/messenger-newsblog/am-newsblog.dtd#20

Comment 5

[Marek Stępień [:marcoos, inactive]]

This is weird, many locales use non-ascii characters in the name of this folder, e.g. Polish uses "Aktualności i blogi" (where ś is a two-byte unicode char) and don't suffer from this problem.

http://lxr.mozilla.org/l10n-mozilla1.8/search?string=rss.hostname

Comment 6

[Axel Hecht [:Pike]]

Let's get some more info on this, Scott, Pavel, I see the two of you in the bonsai blame/cvs hist of rss.rdf localization. See bug 259705 and bug 254008, too.

Comment 7

[Channy Yun [:channy]]

Is there any progression for this issue? Because this problem is still on tb 2 ko version, I should fix this bug.

Comment 8

[Magnus Melin [:mkmelin]]

If you didn't notice, the core fix is bug 313525.

Comment 9

[Channy Yun [:channy]]

Axel, can I fix this bug before releases Thunderbird 2.0.0.4?

Comment 10

[Axel Hecht [:Pike]]

The code for tb2004 is wrapped up already, it's just the build that's lagging. So, sorry, no.

Comment 11

[Channy Yun [:channy]]

So, I want to fix this bug in tb 2.0.0.5. Please review it.
Now, tb 2.0.0.4 doesn't be worked RSS functions. 

Comment 12

[Scott MacGregor]

Axel, are you ok with us taking the quick korean fix for the brannch, while we figure out how to best fix the real problem in Bug 313525 ?

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 262422 [details] [diff] [review]
am-newsblog.dtd.patch

well, ok.

[ko] approval for un-translating rss account description for 1.8.1.5. Please use the fixed1.8.1.5 and verified1.8.1.5 keywords to track landing and testing.