Thunderbird installation instructions are incorrect if EULA present

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
11 years ago
2 years ago

People

(Reporter: fligtar, Assigned: clouserw)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
The Thunderbird installation instructions are incorrect if the add-on has a EULA, as right clicking on the file will only save the EULA page. The instructions should probably not appear on these pages and instead appear on the EULA page.
(Assignee)

Comment 1

10 years ago
Created attachment 296891 [details] [diff] [review]
Only show instructions on EULA page.

Bug 401272 changed the button labels and fixed the mime types for downloading tb attachments.  This removes the instructions from the page if there is a EULA.
Assignee: nobody → clouserw
Status: NEW → ASSIGNED
Attachment #296891 - Flags: review?

Comment 2

10 years ago
Comment on attachment 296891 [details] [diff] [review]
Only show instructions on EULA page.

Hm. I don't think it works like this: This patch won't show the instructions at all if there's a EULA present, not even on the policy page.

I believe while we should not show the box on the page when the button links to the policy page, we should still display the box on the policy page itself.

Is there a variable we can check ($this->action or so?) in order to find out if we are currently on the policy page or not?
Attachment #296891 - Flags: review-

Comment 3

10 years ago
Comment on attachment 296891 [details] [diff] [review]
Only show instructions on EULA page.

Oh, in fact, as you pointed out, your patch *does* behave the way I described.

In that case, r+ing. This is good to go. :)
Attachment #296891 - Flags: review- → review+
Attachment #296891 - Flags: review?
(Assignee)

Comment 4

10 years ago
thanks, r9605
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.