378902 - Unable to delete toolbar bookmarks from Organize Bookmarks

Status: RESOLVED DUPLICATE of bug 375677

(Firefox :: Bookmarks & History, defect)

Description

[Marcia Knous [:marcia]]

Seen testing with a clean profile, using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.4pre) Gecko/2007042503 BonEcho/2.0.0.4pre. Testing on a Win Vista machine running Home Basic. I also was able to reproduce this on the other Vista machines in the QA lab.

STR:

1. After launching Firefox, add some bookmarks to your bookmarks toolbar. I also click on each bookmark after adding so the favicon would show in the toolbar.
2. Go to Organize Bookmarks. Highlight all the bookmarks in the bookmarks toolbar, including the two default ones. Try using the "Delete" icon to delete them en masse. Nothing happens.

Expected: The Bookmarks would be deleted from the toolbar.

When I try to delete them individually, I see the following error message in the JS console:

Error: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsITransactionManager.doTransaction]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: file:///C:/Program%20Files/Bon%20Echo/components/nsBookmarkTransactionManager.js :: bkmkTxnMgrCandC :: line 296"  data: no]
Source File: file:///C:/Program%20Files/Bon%20Echo/components/nsBookmarkTransactionManager.js
Line: 296

Possible regression from Bug 247116? Adding mossop...more information to follow re: other platforms.

Comment 1

[Marcia Knous [:marcia]]

Restarting the browser does seem to clear the issue on Vista. After I restarted the bookmarks were removed from the toolbar. I also tried importing a set of bookmarks from IE. They did not show initially until I restarted the browser.

Comment 2

[Marcia Knous [:marcia]]

I can also confirm this on Win XP and Intel Mac. On XP, when I get in the funkified state, I cannot add any new bookmarks. But restarting seems to restore everything, both the removal of bookmarks and the addition of new ones that have been added.

I was using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.4pre) Gecko/2007042603 BonEcho/2.0.0.4pre on Win XP and the same build on the Intel mac.

Bug 247116 is not the likely culprit, as tomcat and I see this bug on earlier builds (2.0.0.3) before the checkin occured. stay tuned for more.

Comment 3

[Marcia Knous [:marcia]]

Deleting a group of bookmarks that you have selected seems to work fine in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.1) Gecko/2006120417 Firefox/2.0.0.1. I also checked FF 2 and the 1.5 branch and this works as expected. Tomcat and I notice the issue present starting in Firefox 2.0.0.2.

Comment 4

[Carsten Book [:Tomcat]]

same problem also on Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US;
rv:1.8.1.2) Gecko/2007020823 Firefox/2.0.0.2 - so this is not a regression from
Bug 247115

It seems this regressed between 2001 and 2002.

Comment 5

[Marcia Knous [:marcia]]

Perusing the list bonsai checkins during that dev period (http://tinyurl.com/2ltq9l), I see a few bookmarks related checkins by robert sayre and seth. adding them to the bug. sorry for the false alarm, mossop.

Comment 6

[Phil Ringnalda (:philor)]

See also bug 373691, bug 373800, bug 375677.