Closed Bug 381191 Opened 17 years ago Closed 8 years ago

[meta] Reduce code duplication in js xpcom by using the import module (XPCOMUtils.jsm)

Categories

(Core Graveyard :: Tracking, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: richwklein, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: meta)

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.4pre) Gecko/20070518 Firefox/2.0.0.3 Navigator/9.0a13
Build Identifier: 

This is the toolkit bug to start using the new the new js code sharing system
from bug 238324.  I couldn't find a good component for it so I'm putting it in XULRunner.  This should greatly reduce the amount of code duplication for
javascript xpcom module registration.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Depends on: 238324
The firefox version of this is bug 381189 and the thunderbird version is bug 381190.
confirming to get on bug radar.  Richard, see bug 381190 comment 4 regarding bug management.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Per Alex's comment #4 in bug 381190, I'm going to morph this into a tracking bug and file individual bugs for each component.
Keywords: meta
Summary: Reduce code duplication in js xpcom by using the import module (XPCOMUtils.jsm) → [meta] Reduce code duplication in js xpcom by using the import module (XPCOMUtils.jsm)
There has been some discussion that one bug is sufficient for each major area
of change.  I can file individual bugs or place all the patches here.  Below is
the list of files for toolkit that should be changed:

netwerk/base/src/nsProxyAutoConfig.js
content/xslt/src/xslt/txEXSLTRegExFunctions.js
editor/ui/nsComposerCmdLineHandler.js
embedding/browser/activex/src/plugin/nsAxSecurityPolicy.js
embedding/components/ui/helperAppDlg/nsHelperAppDlg.js
embedding/components/ui/progressDlg/nsProgressDialog.js
toolkit/components/console/jsconsole-clhandler.js
toolkit/components/feeds/src/FeedProcessor.js
toolkit/passwordmgr/src/nsLoginInfo.js
toolkit/passwordmgr/src/nsLoginManager.js
toolkit/passwordmgr/src/nsLoginManagerPrompter.js
toolkit/passwordmgr/src/storage-Legacy.js
toolkit/places/src/nsLivemarkService.js
toolkit/startup/src/nsCloseAllWindows.js
toolkit/url-classifier/nsUrlClassifierLib.js
toolkit/url-classifier/nsUrlClassifierListManager.js
toolkit/url-classifier/nsUrlClassifierTable.js
toolkit/urlformatter/src/nsURLFormatter.js
toolkit/nsDefaultCLH.js
toolkit/mozapps/update/src/nsPostUpdateWin.js
toolkit/xulrunner/setup/nsXULAppInstall.js


If anyone else wants to take on some of these files feel free.
Note bug 381651, which may change the XPCOMUtils interface a bit.
Since this has become a meta bug, it wouldn't hurt to add the dependencies :)
Component: XULRunner → Tracking
Depends on: 381189, 381190, 381226, 381227, 381254
Product: Toolkit → Core
QA Contact: xulrunner → chofmann
Version: unspecified → Trunk
Marking all tracking bugs which haven't been updated since 2014 as INCOMPLETE.
If this bug is still relevant, please reopen it and move it into a bugzilla component related to the work
being tracked. The Core: Tracking component will no longer be used.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.