381441 - drag to bottom in Bookmarks Manager generates error

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070521 Minefield/3.0a5pre ID:2007052107 [cairo]

repro:
Open FF
Open Bookmarks Manager
open a folder in the manager
drag a bookmark to the bottom place
-- sometimes more steps are needed
-- drag the last bookmark up a place
-- drag a bookmark to the bottom places

result:
Error: 'Illegal value' when calling method: [nsITreeView::getParentIndex] = NS_ERROR_ILLEGAL_VALUE
Source file: chrome://global/content/nsDragAndDrop.js
Line: 397

Comment 1

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070531 Minefield/3.0a5pre ID:2007053104 [cairo]

I can't reproduce this anymore because D&D in the manager is totally screwed up.

D&D inside 1 folder
1. You can't drag a bookmark to the lowest place anymore
2. You can drag a bookmark from top to bottom, but it needs to be 3 places
down to get it appear 2 places down.
3  You can drag from bottom to top, but it ends up above where you draggged it to.

nb: we seem to be calculating the wrong position in both directions

bottom line, the error is gone though

Comment 2

[Dietrich Ayala (:dietrich)]

(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070531
> Minefield/3.0a5pre ID:2007053104 [cairo]
> 
> I can't reproduce this anymore because D&D in the manager is totally screwed
> up.
> 
> D&D inside 1 folder
> 1. You can't drag a bookmark to the lowest place anymore
> 2. You can drag a bookmark from top to bottom, but it needs to be 3 places
> down to get it appear 2 places down.
> 3  You can drag from bottom to top, but it ends up above where you draggged it
> to.
> 
> nb: we seem to be calculating the wrong position in both directions
> 

see bug 381751 for this

Comment 3

[(not reading, please use [e-mail] instead)]

The issue in comment #1 is fixed by bug #382679 and bug #385970, so marking fixed.

Comment 4

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre)
Gecko/2007072505 Minefield/3.0a7pre

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv