bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Drag and drop at index 0 of open folders reacts incorrectly to mouse position

VERIFIED FIXED in Firefox 3 alpha6

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: Christine Yen, Assigned: Christine Yen)

Tracking

Trunk
Firefox 3 alpha6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

1.56 KB, patch
(not reading, please use seth@sspitzer.org instead)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
In general, DnD within a tree has to resolve the location of the mouse (which row it's hovering over, as seen by the tree) with where the the drop indicator is telling the user that the item will be dropped.

In http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/tree.xml#898,
if 'orientation' == -1, insert above hovered row, ending up at 'index'
if 'orientation' == 1, insert below the hovered row, ending up at 'index' + 1

This behavior messes up DnD around folders, where the second case -- where the drop indicator tells the user that the item should be inserted at index 0 in the folder -- actually causes the orientation to be set to 1 and for the item to be inserted below the hovered row, or one row below the folder in the parent container. This is what causes the "popping out of the folder" effect seen in Bug #381751.
(Assignee)

Comment 1

11 years ago
Created attachment 269929 [details] [diff] [review]
patch
Attachment #269929 - Flags: review?(sspitzer)
(Assignee)

Comment 2

11 years ago
Created attachment 269931 [details] [diff] [review]
previous patch, minus the typo in the header
Attachment #269929 - Attachment is obsolete: true
Attachment #269931 - Flags: review?(sspitzer)
Attachment #269929 - Flags: review?(sspitzer)

Updated

11 years ago
Attachment #269931 - Attachment is patch: true
Attachment #269931 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 3

11 years ago
Created attachment 269940 [details] [diff] [review]
patch v2
Attachment #269931 - Attachment is obsolete: true
Attachment #269940 - Flags: review?(sspitzer)
Attachment #269931 - Flags: review?(sspitzer)
OS: Mac OS X → All
Hardware: PC → All
Target Milestone: --- → Firefox 3 alpha6
Comment on attachment 269940 [details] [diff] [review]
patch v2

r=sspitzer
Attachment #269940 - Flags: review?(sspitzer) → review+
fix landed along with bug #382679
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Depends on: 382679
Resolution: --- → FIXED
(Assignee)

Updated

11 years ago
Summary: Drag and drop around folders reacts incorrectly to mouse position → Drag and drop at index 0 of open folders reacts incorrectly to mouse position

Comment 6

11 years ago
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre)
Gecko/2007072505 Minefield/3.0a7pre
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.