382450 - new mail notification alert on linux does not respect system colors

Status: RESOLVED DUPLICATE of bug 382299

(Thunderbird :: Mail Window Front End, defect)

Description

[Patrick Wagstrom]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: version 2.0.0.0 (20070326)

I've only tested this problem on linux, so I don't know if it's persistent.

When new mail is received in Thunderbird, a little notification alert pops up.  This provides information about who sent the message, the first line of text, etc.  However, it also sets the CSS background color of the XUL widget without setting the CSS foreground color.  So, if you're using a white font on a dark background, you'll end up getting your normal white font, on a fixed white background.  In other words, invisible notifications.

In the case where a widget specifies a mandatory background color, it should also specify a foreground color.  I've corrected this by modifying chrome/skin/classic/messenger/newmailalert.css and chrome/skin/class/message/neMailAlertUnix.css to specify a black foreground color.


Reproducible: Always

Steps to Reproduce:
1. have white for default font color
2. wait for email
3. examine notification alert area
Actual Results:  
Most of the information in the notification area is invisible (white on white)

Expected Results:  
The information in the notification area should be readable.

Comment 1

[Patrick Wagstrom]

Attachment: patch to fix the CSS problems

Here's the patch that should fix the CSS problems for linux users who have a white font.

Comment 2

[Adam Guthrie]

Could you attach your patch to bug 382299? Also, when do you, you should do a CVS diff (-up8 are good options to use) and ask for review from Scott MagGregor (mscott@moz). Thanks!

Comment 3

[Patrick Wagstrom]

patch posted, how do I request review?  It is not obvious from the UI or a few google searches.  For a person who is not a mozilla contributor, this is a bit of a drawback.