382299 - New mail notification window (alert) doesn't comply with high-contrast GNOME theme

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Tim Miao]

New mail notification popup window is not compliant with gnome desktop theme settings.

Steps to reproduce:
1. Change gnome desktop theme to high contrast large print inverse.
2. Start thunderbird and compose a new message to yourself.
3. Send and receive mail.

Expected result:
After step 3, new mail notification window will be popup, it should be compliant with selected theme settings.

Actual result:
This notification window is not compliant with selected theme settings.

Comment 1

[Adam Guthrie]

Can you provide a screenshot of the alert?

Comment 2

[Tim Miao]

Attachment: screenshot

Comment 4

[Patrick Wagstrom]

Attachment: patch to fix color issues

this is the updated patch against CVS from today

Comment 5

[Scott MacGregor]

Comment on attachment 266639 [details] [diff] [review]
patch to fix color issues

I don't think anyone has reviewed this patch yet so removing the plus. 

Asking Magnus and myself.

Comment 6

[Ginn Chen]

Can we use 
 background-color: -moz-Dialog;
 color: -moz-DialogText;
?

I think we should not hardcoded bg/fg color to white/black.

Comment 7

[Scott MacGregor]

Comment on attachment 266639 [details] [diff] [review]
patch to fix color issues

I think Ginn is on the right track with his suggestion. Can you incorporate it into your patch?

Comment 8

[Magnus Melin [:mkmelin]]

While you're at it, it turned out that the min-height and background-color rules on #newMailAlertNotification in the newMailAlertUnix.css file aren't needed - so we can get rid of them like on the branch. http://lxr.mozilla.org/mozilla1.8/source/mail/themes/qute/mail/newMailAlertUnix.css#9

Comment 9

[Patrick Wagstrom]

Attachment: updated version of patch to utilize mozilla symbolic names

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 266916 [details] [diff] [review]
updated version of patch to utilize mozilla symbolic names

Looks good. r=[e-mail]

Comment 11

[Adam Guthrie]

Ginn Chen checked this in at 2007-06-08 00:22, FWIW.