383860 - [Proto] Event dialog: Importance label is not localizable

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Hubert Gajewski]

"Importance" label in sun-calendar-event-dialog.xul (line 857) is not localizable.

Comment 1

[Hubert Gajewski]

Attachment: Patch for trunk (proposal)

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 267804 [details] [diff] [review]
Patch for trunk (proposal)

Mickey, could you please take a look at this two-line patch. Thanks.

Comment 3

[Hubert Gajewski]

BTW - I found in sun-calendar-event-dialog.dtd unused entities:
<!ENTITY event.private.label                              "Private" >
<!ENTITY event.public.label                               "Public" >
<!ENTITY event.confidential.label                         "Time and Date Only" >

In sun-calendar-event-dialog.xul (id="status-bar") I see entities:
<label value="&event.menu.options.privacy.public.label;"/>
<label value="&event.menu.options.privacy.confidential.label;"/>
<label value="&event.menu.options.privacy.private.label;"/>

I think that we should change these labels to:
<label value="&event.private.label;"/>
<label value="&event.public.label;"/>
<label value="&event.confidential.label;"/>

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
The also exists a bug for the prototype event dialog localization issues: Bug 359353

Comment 5

[Michael Büttner (no reviews TFN)]

(In reply to comment #3)
Feel free to submit a patch for these changes, it would be more than welcome...

Comment 6

[Michael Büttner (no reviews TFN)]

Comment on attachment 267804 [details] [diff] [review]
Patch for trunk (proposal)

Thanks for the patch, r=mickey.

Comment 7

[Hubert Gajewski]

Attachment: Full patch for trunk

All changes in one patch.

Comment 8

[Michael Büttner (no reviews TFN)]

Comment on attachment 269601 [details] [diff] [review]
Full patch for trunk

This patch contains the changes to the xul file, but the related changes to the dtd file are missing. Besides that I think it would be a good idea to rename all the entities "event.menu.xxx.*" to "event.*". But since this bug is on the 'post 0.5 checkin'-list I'm now going ahead and close this one off. You could do me a favor and address the outstanding renaming issue in a spin-off bug. I'm taking the initial revision of this patch for now. Thanks for taking care...

Comment 9

[Michael Büttner (no reviews TFN)]

patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED

Comment 10

[Hubert Gajewski]

Verified (later it was changed to priority - bug 395928)