Closed Bug 383860 Opened 13 years ago Closed 13 years ago

[Proto] Event dialog: Importance label is not localizable

Categories

(Calendar :: General, defect)

Lightning 0.5
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: hubert+bmo, Assigned: hubert+bmo)

References

()

Details

(Keywords: l12y)

Attachments

(2 files)

"Importance" label in sun-calendar-event-dialog.xul (line 857) is not localizable.
Summary: Importance label is not localizable → [Proto] Event dialog: Importance label is not localizable
Comment on attachment 267804 [details] [diff] [review]
Patch for trunk (proposal)

Mickey, could you please take a look at this two-line patch. Thanks.
Attachment #267804 - Flags: review?(michael.buettner)
Assignee: nobody → hubert.gajewski
Keywords: l12y
BTW - I found in sun-calendar-event-dialog.dtd unused entities:
<!ENTITY event.private.label                              "Private" >
<!ENTITY event.public.label                               "Public" >
<!ENTITY event.confidential.label                         "Time and Date Only" >

In sun-calendar-event-dialog.xul (id="status-bar") I see entities:
<label value="&event.menu.options.privacy.public.label;"/>
<label value="&event.menu.options.privacy.confidential.label;"/>
<label value="&event.menu.options.privacy.private.label;"/>

I think that we should change these labels to:
<label value="&event.private.label;"/>
<label value="&event.public.label;"/>
<label value="&event.confidential.label;"/>
(In reply to comment #3)
The also exists a bug for the prototype event dialog localization issues: Bug 359353
Assignee: hubert.gajewski → nobody
Component: Provider: WCAP → General
QA Contact: wcap-provider → general
QA Contact: general → wcap-provider
Assignee: nobody → hubert.gajewski
(In reply to comment #3)
Feel free to submit a patch for these changes, it would be more than welcome...
Comment on attachment 267804 [details] [diff] [review]
Patch for trunk (proposal)

Thanks for the patch, r=mickey.
Attachment #267804 - Flags: review?(michael.buettner) → review+
OS: Linux → All
Whiteboard: [checkin needed after 0.5]
All changes in one patch.
Attachment #269601 - Flags: review?(michael.buettner)
Status: NEW → ASSIGNED
Comment on attachment 269601 [details] [diff] [review]
Full patch for trunk

This patch contains the changes to the xul file, but the related changes to the dtd file are missing. Besides that I think it would be a good idea to rename all the entities "event.menu.xxx.*" to "event.*". But since this bug is on the 'post 0.5 checkin'-list I'm now going ahead and close this one off. You could do me a favor and address the outstanding renaming issue in a spin-off bug. I'm taking the initial revision of this patch for now. Thanks for taking care...
Attachment #269601 - Flags: review?(michael.buettner) → review-
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
QA Contact: wcap-provider → general
Hardware: PC → All
Whiteboard: [checkin needed after 0.5]
Target Milestone: --- → 0.7
Verified (later it was changed to priority - bug 395928)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.