383909 - Clean up mozilla/themes after suite moving to toolkit

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Simon Paquet [:sipaq]]

Attachment: Remove unneeded ifdefs on the trunk

Now that SeaMonkey is an XUL app one should start clearing up some of the ifdefs.

One needs to keep anything that is ifdef MOZ_XUL_APP and throw out anything that
is 'else' or ifndef.

I'm not sure, whether sr is still needed for everything in SeaMonkey, as I'm a bit unfamiliar with the project. Mark, I would really appreciate it, if you could select an appropriate super-reviewer, if it turns out, that sr is still needed.

Comment 1

[Simon Paquet [:sipaq]]

Attachment: List of files to be deleted

Comment 2

[Simon Paquet [:sipaq]]

Comment on attachment 267847 [details] [diff] [review]
Remove unneeded ifdefs on the trunk

Moving review request to Neil, as per KaiRo's suggestion on IRC.

Comment 3

[Mark Banner (:standard8)]

The patch in general looks good. The main thing I'd be concerned about here is breaking embed-jar that I know Camino use (and possibly others).

http://mxr.mozilla.org/seamonkey/source/embedding/config/embed-jar.mn

Non XUL apps (i.e. just Camino) are still building in themes:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/toolkit-tiers.mk&rev=1.10&mark=202-204#202

So I think here we need to be at least notifying Camino that it happens and preferably working out solutions to any issues.

Comment 4

[[e-mail]]

Comment on attachment 267847 [details] [diff] [review]
Remove unneeded ifdefs on the trunk

May I suggest that someone ports the following bugs from xpfe classic to toolkit first? 358533 345178 228319 319043

Comment 5

[Simon Paquet [:sipaq]]

(In reply to comment #4)
> May I suggest that someone ports the following bugs from xpfe classic to
> toolkit first? 358533 345178 228319 319043

That is way beyond my skills. Are there bugs for the porting efforts?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> bug 358533 bug 345178 bug 228319 bug 319043

(linkifying)

Comment 7

[Stefan [:stefanh]]

(In reply to comment #4)
> (From update of attachment 267847 [details] [diff] [review])
> May I suggest that someone ports the following bugs from xpfe classic to
> toolkit first? 358533 345178 228319 319043
> 
Afaics, the only thing left that needs/ought to be ported to toolkit is bug 228319. Pinstripe's menu.css has just a border-top rule for menuseparator, so the porting is only needed to the winstripe/gnomestripe versions of menu.css):

- Bug 358533 looks like a cocoa issue.
- Bug 319043 is ported to toolkit (bug 307969 and bug 389187)
- Bug 345178: suite's both tabbrowser.css has the needed style rules

Comment 8

[Robert Kaiser]

Camino is the last user of what's left in mozilla/themes, once it can stop building this, we can remove the whole dir, given we don't have anything left to port to toolkit.

Comment 9

[[e-mail]]

Comment on attachment 267847 [details] [diff] [review]
Remove unneeded ifdefs on the trunk

This patch as it stands isn't applicable any more.

Comment 10

[Simon Paquet [:sipaq]]

What in mozilla/themes is Camino still using? How should we proceed here?

Comment 11

[Stefan [:stefanh]]

(In reply to comment #10)
> What in mozilla/themes is Camino still using? How should we proceed here?
> 

afaik Camino uses at least mozilla/themes/classic/global (could be more). Camino also package the old xpfe xul widgets - see bug 389140. Camino should package toolkit/content/widgets and pinstripe/global instead.

Comment 12

[Stefan [:stefanh]]

That is, if everyone is 100% sure that Camino is the only consumer of mozilla/themes, you could probably nuke all the non-mac stuff.

Comment 13

[Simon Paquet [:sipaq]]

Moving back to nobody. Let someone else sort out the Camino usage of XPFE mess.

Comment 14

[Robert Kaiser]

There is no themes/ in mozilla-1.9.1 or mozilla-central, so this has been fixed in some way.