384914 - Autoscroll marker shows up at the wrong place on print preview, no scrolling

Status: RESOLVED DUPLICATE of bug 1393424

(Core :: Print Preview, defect)

Description

[Martijn Wargers (dead)]

When you do print preview and then middle-click on the page to use autoscroll, the autoscroll popup pops up at the wrong place, far too much to the top and the left than what should happen. Also scrolling doesn't work.
I suspect bug 373091 is basically the same issue, which would perhaps make it a regression from bug 369834.

Comment 1

[Martijn Wargers (dead)]

To explain, the autoscroll code was changed, to use a popup now (bug 242621), that's the reason why this bug has shown up just recently

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Gavin, I looked at this yesterday, and given bug 373091 I was assuming this is not a bug in any code I touched.

Comment 4

[Michael Ventnor]

Attachment: Block autoscroll marker on print preview

I think this is the best we can do for now.

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #4)
> Created an attachment (id=269828) [details]
> Disable autoscroll on print preview
> 
> I think this is the best we can do for now.
> 

1) I can't get any autoscroll on print preview in SM or Fx.  Does it really exist?
2) If the positioning is wrong, I'd rather fix it.  I can't do that if I can't figure out how to activate it ;)

Comment 6

[Michael Ventnor]

(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=269828) [details] [details]
> > Disable autoscroll on print preview
> > 
> > I think this is the best we can do for now.
> > 
> 
> 1) I can't get any autoscroll on print preview in SM or Fx.  Does it really
> exist?
> 2) If the positioning is wrong, I'd rather fix it.  I can't do that if I can't
> figure out how to activate it ;)
> 

Well, no it doesn't really exist, see my dupe. :) The correct title really should be disable autoscroll _marker_, because when you try to autoscroll under Print Preview it will scroll the original page, not the print preview (so when you close PP, the page is at a different scroll position).

PP can't receive autoscroll commands because it isn't part of the browser widget, so just totally blocking autoscroll is the only thig I can think of.

Comment 7

[Eli Friedman]

Yeah, that's my fault :( The whole thing is a real mess, though.  I was hoping to rewrite print preview to make it sane at some point, but I didn't have the time for 1.9.

Comment 8

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Created an attachment (id=269828) [details] [details] [details]
> > > Disable autoscroll on print preview
> > > 
> > > I think this is the best we can do for now.
> > > 
> > 
> > 1) I can't get any autoscroll on print preview in SM or Fx.  Does it really
> > exist?
> > 2) If the positioning is wrong, I'd rather fix it.  I can't do that if I can't
> > figure out how to activate it ;)
> > 
> 
> Well, no it doesn't really exist, see my dupe. :) The correct title really
> should be disable autoscroll _marker_, because when you try to autoscroll under
> Print Preview it will scroll the original page, not the print preview (so when
> you close PP, the page is at a different scroll position).

You mean, start autoscroll, then somehow print preview while still scrolling?  I checked whether the page scrolled if I acted like I was autoscrolling on the print preview, and it didn't... I must still be missing something.

Comment 9

[Michael Ventnor]

(In reply to comment #8)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (In reply to comment #4)
> > > > Created an attachment (id=269828) [details] [details] [details] [details]
> > > > Disable autoscroll on print preview
> > > > 
> > > > I think this is the best we can do for now.
> > > > 
> > > 
> > > 1) I can't get any autoscroll on print preview in SM or Fx.  Does it really
> > > exist?
> > > 2) If the positioning is wrong, I'd rather fix it.  I can't do that if I can't
> > > figure out how to activate it ;)
> > > 
> > 
> > Well, no it doesn't really exist, see my dupe. :) The correct title really
> > should be disable autoscroll _marker_, because when you try to autoscroll under
> > Print Preview it will scroll the original page, not the print preview (so when
> > you close PP, the page is at a different scroll position).
> 
> You mean, start autoscroll, then somehow print preview while still scrolling? 
> I checked whether the page scrolled if I acted like I was autoscrolling on the
> print preview, and it didn't... I must still be missing something.
> 

No: open print preview, start autoscroll, move mouse, notice that preview doesn't scroll, cancel autoscroll, close print preview, notice that original page is in different scroll position.

Comment 10

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

I can't reproduce that in FF2, SeaMonkey 1.1, or SeaMonkey trunk.  In SeaMonkey, it scrolls to the top when I close print preview, whether or not I click the middle mouse button.

Comment 11

[Asaf Romano (gone)]

Comment on attachment 269828 [details] [diff] [review]
Block autoscroll marker on print preview

I cannot this since non-native printpreview is disabled on mac. CTho (if he manages to reproduce this; mpa=me) or gavin should review this.

That said, this seems like a work around for bug 373091 which is a trunk-only regression. Please land this only if we cannot get a resolution there before beta-time.

Comment 12

[Michael Ventnor]

(In reply to comment #10)
> I can't reproduce that in FF2, SeaMonkey 1.1, or SeaMonkey trunk.  In
> SeaMonkey, it scrolls to the top when I close print preview, whether or not I
> click the middle mouse button.

But you didn't try in Firefox trunk, the only place I can reproduce this ;)

(In reply to comment #11)
> (From update of attachment 269828 [details] [diff] [review])
> That said, this seems like a work around for bug 373091 which is a trunk-only
> regression. Please land this only if we cannot get a resolution there before
> beta-time.

Not really, the icon isn't the only problem. The actual scrolling doesn't work too, since the scrolling commands are sent to the original page instead of the print preview. Disabling autoscroll during print preview seems like the easiest way out especially at this stage of the schedule, and the current quality (or lack thereof) of the print codebase.

Comment 13

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

> But you didn't try in Firefox trunk, the only place I can reproduce this ;)

Ah, I can reproduce it there :)  I guess we can land this as Mano specified, but could you file another bug on re-enabling it and getting it to work properly (and cc me)?

Comment 14

[Martijn Wargers (dead)]

Attachment: patch?

This fixes it, but it makes the print preview page even smaller than it already is.

Comment 15

[Martijn Wargers (dead)]

Attachment: this makes the print preview page a decent size again

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 319871 [details] [diff] [review]
patch?

that line is there for a reason. Why do you think this is the right thing to do?

Comment 19

[Botond Ballo [:botond]]

Forward-duping to bug 1393424 where this was fixed.