385771 - disallow item-annotations for invalid item ids

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

assertion when you bookmark a page and you've got stale annotations

mano fixed bug #375629, so we should be deleting annotations.

but with older profiles before his fix (or not sure how?) people can end up in a state with bookmarkPropertiesDialog/lastUsed annotations that point to folders that don't exist.

Additionally (in the case of one user, :stephend), one bookmarkPropertiesDialog/lastUsed annotation pointed to item_id of 0.

We should not gracefully handle this, but in debug and nightly builds users like stephend will see an assert (see screen shot #1).

One idea:  on detecting this (or other?) stale annotations, remove them.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot #1 (of the assert of nightlies and debug builds would see)

Comment 2

[Asaf Romano (gone)]

what we really should do is validate aItemId in SetItemAnnotation*

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 269756 [details] [diff] [review]
patch

r=me, thanks.

Comment 5

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/nsAnnotationService.cpp 1.25
mozilla/toolkit/components/places/src/nsNavBookmarks.cpp 1.104
mozilla/toolkit/components/places/src/nsNavBookmarks.h 1.44
mozilla/toolkit/components/places/tests/unit/test_annotations.js 1.9

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Am I right to infer this change doesn't remove already-written invalid item IDs, it just prevents them from being written incorrectly in the future?  (If not, I still see https://bugzilla.mozilla.org/attachment.cgi?id=269681 in today's trunk build.)

Comment 7

[Asaf Romano (gone)]

Right.

Comment 8

[(not reading, please use [e-mail] instead)]

asaf:  based on stephen's question and your response, I think we should spin up another bug about the assertion, and about "on detecting this (or other?) stale annotations, remove them".

Comment 9

[Asaf Romano (gone)]

I don't think it's worth it given that
 1. JS-Assertions will be turned off post-beta
 2. You cannot get into this state starting with a6.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv