375629 - The annotations of an item (bookmark/folder) must be removed when the item itself is removed

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

The annotations of an item (bookmark/folder/history item) must be removed when the item itself is removed.

Comment 1

[Phil Ringnalda (:philor)]

See also bug 319455, bug 327162 and bug 341035

Comment 2

[(not reading, please use [e-mail] instead)]

taking, per dietrich.

Comment 5

[tabmix.onemen]

Attachment: proposing patch ver 1

this patch only deal with bookmarks annotations not with history annotations.

even if you will decide to do the remove annotations in nsNavBookmarks.cpp
this patch contain more fixes that need your approval
if you want i can split this patch 

changes list
===================================================================
PlacesCreateFolderTransaction undoTransaction:
  remove folder annotations.
  fixes typo in _childItemsTransactions loop.
  remove the folder after undoing its _childItemsTransactions.

PlacesCreateItemTransaction undoTransaction:
  remove annotations.
  remove keyword.
  remove the item after undoing its _childTransactions.

PlacesCreateSeparatorTransaction doTransaction:
  save the new separator index if we passe new index as -1 we can't undo the transaction without a valid index.
          
PlacesCreateLivemarkTransaction undoTransaction:
  remove annotations.

PlacesMoveItemTransaction doTransaction/undoTransaction:
  move keyword.
  remove old item keyword and annotations if the we have new ID.

PlacesRemoveFolderTransaction doTransaction:
  save and remove annotations.
  don't remove children for livmark here we do it in nsILivemarksService::deleteLivemarkChildren.

PlacesRemoveFolderTransaction undoTransaction:
   restore annotations and if the folder is livemark reloadLivemarkFolder.
   also chaned nsILivemarksService::reloadLivemarkFolder to update livemark internal table.

PlacesRemoveItemTransaction doTransaction:
  save and remove keyword.
  remove annotations.

PlacesRemoveItemTransaction undoTransaction:
  restore keyword.
  restore annotations.

PlacesSetLoadInSidebarTransaction doTransaction:
  cleanup.

PlacesEditItemDescriptionTransaction undoTransaction:
  fixes hasAnnotation is not a function of this.utils.

PlacesEditBookmarkMicrosummaryTransaction doTransaction/undoTransaction:
  cleanup.

PlacesSetBookmarksToolbarTransaction
  fixes typo, also fixes the PlacesUtils.toolbarFolderId getter

Comment 6

[Asaf Romano (gone)]

Comment on attachment 263850 [details] [diff] [review]
proposing patch ver 1

We'll do this on the back-end side once we switch over to ID-based annotations, see dependency.

Comment 7

[tabmix.onemen]

did you looked at the other fixes ?
if you want i can post all the other fixes to new bug

Comment 8

[Asaf Romano (gone)]

Please do, thanks.

Comment 9

[Asaf Romano (gone)]

This is fixed now for item item-annotations (bookmarks & folders), I'm leaving the history-annotations part of this bug to bug 319455.

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv