Add parameter to allow "find a specific bug" to accept an empty search

VERIFIED FIXED in Bugzilla 3.0

Status

()

enhancement
VERIFIED FIXED
12 years ago
11 years ago

People

(Reporter: k0u4dz202, Assigned: k0u4dz202)

Tracking

Bugzilla 3.0
Bug Flags:
approval +
approval3.0 +

Details

Attachments

(2 attachments, 1 obsolete attachment)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4) Gecko/20070508 Iceweasel/2.0.0.4 (Debian-2.0.0.4-0etch1)
Build Identifier: 3.0

Bug# 234226 Added javascript and server side validation of the "words" field that prevents it from being empty. On a Bugzilla install with many small projects it is desirable to search for all open bugs easily through this form.

We should add an admin parameter to turn on and off the validation implemented in bug #234226.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attachment #269869 - Flags: review?(LpSolit)
Bah, there was already a bug filed about this, see bug 383640. Next time, do a (non-empty) search first. ;)
Assignee: query-and-buglist → fk7q01p02
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 3.0
Version: unspecified → 3.0
Duplicate of this bug: 383640
Comment on attachment 269869 [details] [diff] [review]
Patch that adds parameter for enabling/disabling empty word quicksearches

>Index: buglist.cgi

>+if (!Bugzilla->params->{'quicksearch_allow_empty_words'} && defined($cgi->param('content')) && $cgi->param('content') =~ /^\s*$/) {

This line is too long, but it can be split on checkin (I will do it). Thanks for the patch! r=LpSolit
Attachment #269869 - Flags: review?(LpSolit) → review+
We had enough complain about this "bug" to take it for 3.0.1. This patch is safe.
Status: NEW → ASSIGNED
Flags: approval3.0+
Flags: approval+
tip:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.357; previous revision: 1.356
done
Checking in Bugzilla/Config/Query.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm,v  <--  Query.pm
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/admin/params/query.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/query.html.tmpl,v  <--  query.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v  <--  search-specific.html.tmpl
new revision: 1.22; previous revision: 1.21
done


3.0:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.351.2.2; previous revision: 1.351.2.1
done
Checking in Bugzilla/Config/Query.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm,v  <--  Query.pm
new revision: 1.3.4.1; previous revision: 1.3
done
Checking in template/en/default/admin/params/query.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/query.html.tmpl,v  <--  query.html.tmpl
new revision: 1.1.4.1; previous revision: 1.1
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v  <--  search-specific.html.tmpl
new revision: 1.20.2.2; previous revision: 1.20.2.1
done
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: relnote
Resolution: --- → FIXED
Comment on attachment 269869 [details] [diff] [review]
Patch that adds parameter for enabling/disabling empty word quicksearches

>Index: template/en/default/admin/params/query.html.tmpl
>===================================================================
>+  quicksearch_allow_empty_words => "Whether to allow a QuickSearch with empty Words." }

Nit: Actually this name is misleading as this is not about QuickSearch functionality but rather only about the Simple/Specific Search.
(In reply to comment #7)
> Nit: Actually this name is misleading as this is not about QuickSearch
> functionality but rather only about the Simple/Specific Search.

  Agreed.
Rename new configuration parameter from quicksearch_allow_empty_words to find_specific_allow_empty_words. This patch is made against BUGZILLA-3_0-BRANCH.
Attachment #270618 - Flags: review?(LpSolit)
I'm fine with this change (or even specific_search_allow_empty_words). Max, Teemu, are you OK with the new param name suggested by Brad?
(In reply to comment #10)
> I'm fine with this change (or even specific_search_allow_empty_words). Max,
> Teemu, are you OK with the new param name suggested by Brad?

  I like your specific_search one.
I like specific_search_allow_empty_words too.
Rename new configuration parameter to specific_search_allow_empty_words instead of find_specific_allow_empty_words. This patch is made against BUGZILLA-3_0-BRANCH.
Attachment #270618 - Attachment is obsolete: true
Attachment #270627 - Flags: review?(LpSolit)
Attachment #270618 - Flags: review?(LpSolit)
Comment on attachment 270627 [details] [diff] [review]
 Rename new configuration parameter to specific_search_allow_empty_words  

>Index: template/en/default/admin/params/query.html.tmpl
>===================================================================
>+  				"Bug page with empty Words." }

This line has tabs which must be removed before commit or trees will burn.

Nit: Adding "field" after Words might make it more clear what this description is talking about.

Otherwise looks fine to me and the name is much better.
Attachment #270627 - Flags: review?(LpSolit) → review+
There's more patches to commit.
Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval+
an empty "Words" field

Would be the best wording, I think.

Flags: approval?
Flags: approval3.0?
Flags: approval3.0+
Flags: approval+
I changed the sentence as per comment 16. I also removed tabs.

tip:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.358; previous revision: 1.357
done
Checking in Bugzilla/Config/Query.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm,v  <--  Query.pm
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/admin/params/query.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/query.html.tmpl,v  <--  query.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v  <--  search-specific.html.tmpl
new revision: 1.23; previous revision: 1.22
done


3.0:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.351.2.3; previous revision: 1.351.2.2
done
Checking in Bugzilla/Config/Query.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm,v  <--  Query.pm
new revision: 1.3.4.2; previous revision: 1.3.4.1
done
Checking in template/en/default/admin/params/query.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/query.html.tmpl,v  <--  query.html.tmpl
new revision: 1.1.4.2; previous revision: 1.1.4.1
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v  <--  search-specific.html.tmpl
new revision: 1.20.2.3; previous revision: 1.20.2.2
done
Status: RESOLVED → VERIFIED
Hi, 

I installed the patch and .... any changes!!!
I still get the warning!!!

P.S. Parameter specific_search_allow_empty_words is ON.
Has been relnoted in 3.0.1.
Keywords: relnote
Duplicate of this bug: 441527
You need to log in before you can comment on or make changes to this bug.