386698 - Console warnings at startup in nsPersistantProperties: the property %s already exists

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

When starting up a trunk version of Thunderbird, we get lots of warnings in the console for things like the property margin already exists, or the property li already exists.

We are using the url formatter service to format the start page url and this is having an unintended side effect of loading chrome://messenger/content/start.xhtml as if it were a string bundle properties file.

We can work around this by reading the url out of prefs ourselves and using nsIUrlFormatter::FormatUrl instead of formaturlpref.

Comment 1

[Scott MacGregor]

Attachment: the fix

this patch avoids using nsIUrlFormatter::formatURLPref. We read the pref ourselves and use nsIUrlFormatter::formatURL.

I also dropped the region from the name of our two helper methods since there's nothing region specific about their implementations.

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 270695 [details] [diff] [review]
the fix

r=me, thanks for quieting that strange and terrible console spew!

Comment 4

[benc]

V/fixed. Mac OS X 10.4

I saw those errors in 1.5.0.7, but not in 2.0.0.4.

When I startup w/ the newer version, I do not see any entries in Error Console.