386903 - remove xpinstall/packager from cvs

Status: RESOLVED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[Robert Kaiser]

SeaMonkey is now using NSIS installer for Windows, and while it would be nice to have a system for making some modules optional for a Linux install, the old xpinstall way is probably not the way to do it.

As bsmedberg mentioned on IRC one time, xpinstall/packager should probably just be removed.

Comment 1

[Benjamin Smedberg]

Note that there still are some files in there used during toolkit packaging, notably:

xptlink.pl (see http://mxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#311)
Packager.pm (see http://mxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/packager.mk#285)

But all the rest should go, good riddance and all that.

Comment 2

[Robert Kaiser]

So all other hits from http://mxr.mozilla.org/mozilla/search?string=xpinstall%2Fpackager can be safely ignored?

Comment 3

[Robert Kaiser]

Attachment: remove xpinstall/packager makefiles from allmakefiles.sh

OK, this patch removes the Makefiles from allmakefiles.sh
Additionally, the review should include cvs removing everything from xpinstall/packager, with the exception of the following files:
xpinstall/packager/Packager.pm
xpinstall/packager/xptlink.pl

I'm not completely sure about those files, please include a review comment if they should stay or can be cvs removed:
xpinstall/packager/pkgcp.pl (referenced from embedding/config/Makefile.in and extensions/java/xpcom/package/Makefile.in)
xpinstall/packager/common/share.t (referenced from toolkit/mozapps/installer/makejs.pl)

Comment 4

[Benjamin Smedberg]

pkgcp.pl should stay... Camino still uses embedding/config, pox on it
I don't know what extensions/java/xpcom needs it for, cc'ing Javier

share.t can go

AFAIK toolkit/mozapps/installer/makejs.pl is not used, and in fact we should remove it along with a bunch of other cruft there:

makeall.pl
makexpi.pl
parseandmakejs.pl

Comment 5

[Robert Kaiser]

Thanks. This has been checked in, per IRC I also did remove the files mentioned in comment #4

Comment 6

[Steffen Wilberg]

Looks like you missed these:
http://mxr.mozilla.org/seamonkey/source/xpinstall/packager/common/
http://mxr.mozilla.org/seamonkey/source/xpinstall/packager/os2/
http://mxr.mozilla.org/seamonkey/source/xpinstall/packager/unix/

Comment 7

[Peter Weilbacher]

OS/2 was still happily using the stuff you removed. But this forces us to think about other installer options sooner rather than later.

Is there a similar bug about removing xpinstall/wizard/?

Comment 8

[Robert Kaiser]

Peter:
I'm somewhat sorry for catching you without specific warnings, but it's been the plan to get rid of XPI-based installers for some time now.

xpinstall/wizard is bug 387450 - should I leave the os2 dirs around (as I missed the one here anyways) or are you happy to get anything you need from older states of CVS?

Comment 9

[Peter Weilbacher]

kairo: please remove them, without packages-os2 they useless now anyway, and I think that's the (only?) file we would have to start from for a new installer.

Comment 10

[Robert Kaiser]

OK, I removed the three remaining dirs as well now.

Peter:
It might be a good idea to start over from the windows packaging lists in the product dirs anyways, like suite/installer/windows/packages

Comment 11

[Ginn Chen]

http://mxr.mozilla.org/seamonkey/source/xpinstall/Makefile.in
is still referring to packager and packager/unix

BTW: How do we generate .tar.bz2 on unix now?

Comment 12

[Ginn Chen]

(In reply to comment #11)
> BTW: How do we generate .tar.bz2 on unix now?
> 

I see.

browser/installer
mail/installer

Comment 13

[Robert Kaiser]

(In reply to comment #11)
> http://mxr.mozilla.org/seamonkey/source/xpinstall/Makefile.in
> is still referring to packager and packager/unix

Thanks. Let's leave this bug FIXED, I'll remove that in bug 387450 along with wizard/

> BTW: How do we generate .tar.bz2 on unix now?

Even better than what you found out yourself, use "make package" from the top-level (in the objdir). For installers (Windows-only), use "make installer" from there.

Comment 14

[Steffen Wilberg]

> Even better than what you found out yourself, use "make package" from the
> top-level (in the objdir). For installers (Windows-only), use "make installer"
> from there.
Really? Where is the code for that? You might want to add that to http://developer.mozilla.org/en/docs/Build_and_Install#Installing_Your_Build

And you should update http://developer.mozilla.org/en/docs/Building_a_SeaMonkey_package as well.
 

Comment 15

[Steffen Wilberg]

> Really? Where is the code for that?
To answer my own question: this was added (fairly recently) by bug 377409.