Closed
Bug 386909
Opened 18 years ago
Closed 18 years ago
clean up mail/config (remove repackaging stuff)
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
Details
Attachments
(1 file)
852 bytes,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
When looking where communicator stuff is used (for bug 386908), I ran across the scary scripts for repacking Thunderbird in mail/config.
From what I see, this is all unused though, and actually everything but mozconfig and version.txt can be removed from that dir, as well as the reference in mail/makefiles.sh
I'd be happy to do this removal if it's OK with Thunderbird devs ;-)
![]() |
Assignee | |
Updated•18 years ago
|
Assignee: nobody → kairo
![]() |
Assignee | |
Comment 1•18 years ago
|
||
Apparently http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/mail/Makefile.in&rev=HEAD&mark=1.7 (bug 245430) got rid of using those files.
![]() |
Assignee | |
Comment 2•18 years ago
|
||
This is the only needed change outside mail/config itself.
I'll take review for this patch to also be a review for removing the following files from mail/config:
basemail-os2
basemail-unix
GenerateManifest.pm
gen_mn.pl
installed-chrome.txt
mail-jar.mn
mail-locales.manifest
Makefile.in
qute-jar.mn
Only mozconfig and version.txt will be left over in this subdirectory.
Attachment #271024 -
Flags: review?(philringnalda)
Comment 3•18 years ago
|
||
Comment on attachment 271024 [details] [diff] [review]
remove config/Makefile from makefiles.sh
r=philringnalda, make the bad things go away, before I blindly patch them again ;)
Attachment #271024 -
Flags: review?(philringnalda) → review+
![]() |
Assignee | |
Comment 4•18 years ago
|
||
Thanks, checked in (after recovering from a conflict of my delete with another checkin to the bogus beasemail-unix file ;-)
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 5•18 years ago
|
||
Lol, mscott patched them most often since he made them unused himself:
http://bonsai.mozilla.org/cvsquery.cgi?branch=HEAD&dir=mozilla%2Fmail%2Fconfig&file=mozconfig%7Cversion.txt&filetype=notregexp&sortby=Date&date=explicit&mindate=2004-07-18+14%3A48
(+190/294) Lines changed.
You need to log in
before you can comment on or make changes to this bug.
Description
•