Closed Bug 387302 Opened 16 years ago Closed 15 years ago

About dialog has no accesskey

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

(Keywords: access)

Attachments

(2 files)

Sunbird's about dialog does not have access keys.  Bug 387015 tracks this for Firefox, and bug 387300 tracks this for Thunderbird.  We should keep Sunbird's About dialog in sync.

I'll post a patch here soon.
Attached patch PatchSplinter Review
Patch to add the access key for Sunbird's About dialog Credits button.  I have renamed the copyright and aboutLink entities as well for the sake of l10n tools.
Attachment #271443 - Flags: review?(mostafah)
Comment on attachment 271443 [details] [diff] [review]
Patch

Moving review to an active calendar developer
Attachment #271443 - Flags: review?(mostafah) → review?(mvl)
Please also have a look at bug 387300 comment 3 to be consistent in naming the entities.
(In reply to comment #3)
> Please also have a look at bug 387300 comment 3 to be consistent in naming the
> entities.
> 

I agree that it's better to make the other entity names consistent, but I think it's out of this bug's scope.

I'm thinking maybe it's better to open a new meta bug to track this issue, and then file individual bugs to fix it in different places of the code.  Finding the inconsistencies is not too difficult.  It would mostly consist of taking a look at each product's dtd files...

What do you think?
(In reply to comment #4)
> What do you think?
> 

See bug 387300 comment 7.
Comment on attachment 271443 [details] [diff] [review]
Patch

updating to reality: I won't be able to review this any time soon
Attachment #271443 - Flags: review?(mvl)
Comment on attachment 271443 [details] [diff] [review]
Patch

Philipp, can you take over the review from mvl, who just dropped this review.
Attachment #271443 - Flags: review?(philipp)
Attachment #271443 - Flags: review?(philipp) → review+
Looks good. Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 0.7
Keywords: verifyme
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6pre) Gecko/20070720 Calendar/0.7pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Keywords: verifyme
Attached file Litmus test case
Here is a Litmus test case for this bug.  I'm not sure who to ask review for, though...
Attachment #273291 - Flags: review?
Attachment #273291 - Attachment mime type: application/txt → text/plain
Comment on attachment 273291 [details]
Litmus test case

No need to ask for a review of the litmus testcase. Just add it to litmus.mozilla.org and set the in-litmus field to '+'
Attachment #273291 - Flags: review?
(In reply to comment #11)
> (From update of attachment 273291 [details])
> No need to ask for a review of the litmus testcase. Just add it to
> litmus.mozilla.org and set the in-litmus field to '+'
> 

I would, but I don't have the required access on litmus.  I need someone else to check this in for me.  And the reason I asked for a review was the instructions at <http://wiki.mozilla.org/Litmus:Adding_Testcases_to_Litmus> for non-admins.
Thanks for the test case, I will move it with others and them set flag to + do not worry about it, as long as in‑litmus=? we will not forget about it
You need to log in before you can comment on or make changes to this bug.