387302 - About dialog has no accesskey

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[(no longer active)]

Sunbird's about dialog does not have access keys.  Bug 387015 tracks this for Firefox, and bug 387300 tracks this for Thunderbird.  We should keep Sunbird's About dialog in sync.

I'll post a patch here soon.

Comment 1

[(no longer active)]

Attachment: Patch

Patch to add the access key for Sunbird's About dialog Credits button.  I have renamed the copyright and aboutLink entities as well for the sake of l10n tools.

Comment 2

[Stefan Sitter [:ssitter]]

Comment on attachment 271443 [details] [diff] [review]
Patch

Moving review to an active calendar developer

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please also have a look at bug 387300 comment 3 to be consistent in naming the entities.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Please also have a look at bug 387300 comment 3 to be consistent in naming the
> entities.
> 

I agree that it's better to make the other entity names consistent, but I think it's out of this bug's scope.

I'm thinking maybe it's better to open a new meta bug to track this issue, and then file individual bugs to fix it in different places of the code.  Finding the inconsistencies is not too difficult.  It would mostly consist of taking a look at each product's dtd files...

What do you think?

Comment 5

[(no longer active)]

(In reply to comment #4)
> What do you think?
> 

See bug 387300 comment 7.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 271443 [details] [diff] [review]
Patch

updating to reality: I won't be able to review this any time soon

Comment 7

[Simon Paquet [:sipaq]]

Comment on attachment 271443 [details] [diff] [review]
Patch

Philipp, can you take over the review from mvl, who just dropped this review.

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Looks good. Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED

Comment 9

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6pre) Gecko/20070720 Calendar/0.7pre

Comment 10

[(no longer active)]

Attachment: Litmus test case

Here is a Litmus test case for this bug.  I'm not sure who to ask review for, though...

Comment 11

[Simon Paquet [:sipaq]]

Comment on attachment 273291 [details]
Litmus test case

No need to ask for a review of the litmus testcase. Just add it to litmus.mozilla.org and set the in-litmus field to '+'

Comment 12

[(no longer active)]

(In reply to comment #11)
> (From update of attachment 273291 [details])
> No need to ask for a review of the litmus testcase. Just add it to
> litmus.mozilla.org and set the in-litmus field to '+'
> 

I would, but I don't have the required access on litmus.  I need someone else to check this in for me.  And the reason I asked for a review was the instructions at <http://wiki.mozilla.org/Litmus:Adding_Testcases_to_Litmus> for non-admins.

Comment 13

[Damian Szczepanik]

Thanks for the test case, I will move it with others and them set flag to + do not worry about it, as long as in‑litmus=? we will not forget about it