387300 - About dialog has no accesskey

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Cédric Corazza]

Attachment: Patch adding accesskeys

Due to bug 387015, I think we should stay in sync for dialogs that are common to several products, so here's the patch.
It also renames the entities for the sake of l10n tools like MT

Comment 1

[(no longer active)]

Thanks Cédric for opening this bug, and for providing this patch.

I think the same thing should be done for Sunbird as well.  I'm opening a new bug for Sunbird.  I'll post the ID here.

Comment 2

[(no longer active)]

(In reply to comment #1)
> I'll post the ID here.
> 

See bug 387302.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Wouldn't it be more consistent if we also change the entity names for aboutVersion            and copyrightText?

Comment 4

[Cédric Corazza]

Henrik,
now that this bug has r+ and sr+, maybe a follow up bug would be better that will also fix this issue for bug 387015 and bug 387302 ?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

These are different components which makes it harder to get r and sr. We don't have to close this bug immediately after the fix went in. Just mark the attachment as [checked in] and attach the follow-up patch here.

Otherwise I don't know if Scott would be ok, with these two small changes and we can carry over the r/sr flags?

Comment 6

[(no longer active)]

(In reply to comment #3)
> Wouldn't it be more consistent if we also change the entity names for
> aboutVersion            and copyrightText?
> 

I agree that it's better to make the other entity names consistent, but I think it's out of this bug's scope.

I'm thinking maybe it's better to open a new meta bug to track this issue, and then file individual bugs to fix it in different places of the code.  Finding the inconsistencies is not too difficult.  It would mostly consist of taking a look at each product's dtd files...

What do you think?

Comment 7

[Phil Ringnalda (:philor)]

Please don't.

Every time you change the name of an entity, 48 localization tinderboxes turn red, and 48 localization teams have to check the log to see that they need to remove aboutVersion from and add aboutVersion.label to their locale, and 48 localization teams have to check the en-US checkin to make certain that it really wasn't any sort of a semantic change in the value, that it really was just a pointless change of name.

We have tens of thousands of open bugs in need of some love, please pick on them instead.

Comment 8

[Phil Ringnalda (:philor)]

mail/base/content/aboutDialog.xul 1.22
mail/locales/en-US/chrome/messenger/aboutDialog.dtd 1.7