378983 - give user control over submit (go) button in the location bar and search bar

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

This was supposed to be done for Firefox 2 (see bug 347754) but time ran out and RTL and other fit and finish issues kept it from happening. A lot of work was done (see attachment 238346 [details] [diff] [review]) which can probably be unbitrotted and re-used.

As I recall, the proposed solution would be that when the "Go" button was placed next to the location bar, the controls would "fuse" together. When it was dragged elsewhere (or removed) it would appear as a standalone button.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: WIP;Winstripe Only

First rough pass at Winstripe.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Bug morphing a little here, without having evaluated Ryan's patch (oops), the essence of this bug is to make it so that the user has control over the "submit" button on the locationbar and searchbar.

And then minusing because Connor's a meanie who won't accept my tears as a blocking argument.

But really-really want!

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: WIP2

Attaching this here so I can clean up my tree a bit. 

This patch (still winstripe only) implements a generic endcap binding for use with both buttons, makes the search button a DnD target and utilizes -moz-border-radius to draw the borders on the endcaps eliminating the background image stitching we used for v2.

Comment 6

[Dão Gottwald [:dao]]

I guess we can close this (WONTFIX / INVALID) since bug 398020 landed.

Comment 7

[Dão Gottwald [:dao]]

Closing for now, as there isn't a static Go /button/ anymore.