388078 - Trunk build broken

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Due to checkin for bug 386903, xforms build is broken on the trunk.  We use makejs.pl which that bug removed.  It is used in conjunction with install.jst to create an install.js.  Looks like to fix this build break we'll have to keep around a static install.js like other extensions do.  I think we really only needed it to get our version number and the space required variables.  But when this is fixed we'll have to build both firefox and seamonkey and make sure nothing else is broken.

Comment 2

[aaronr]

Attachment: patch

I basically moved the contents of install.jst to install.js.  I hardcode the version number and the space required numbers, using the numbers from the install.js that 1.8 branch still generates.  These space required values are just a guide, anyhow.  I also added the function verifyDiskSpace (copied from the chatzilla install.js).

I also think that this change should be made on the 1.8 branch too, just to keep things common between branch and trunk.

Comment 3

[aaronr]

Fix checked into trunk.  Branch is closed, so will have to wait on that until 2.0.0.5 goes out.

Comment 4

[aaronr]

checked into 1.8 branch via bug 410239.

Comment 5

[aaronr]

note: this was effectively backed out of the 1.8 branch with bug 411960.  I shouldn't have checked this into 1.8 in the first place.  Doh!