Closed
Bug 388275
Opened 18 years ago
Closed 12 years ago
non well-formed feed breaks UI
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
References
()
Details
Attachments
(2 files, 2 obsolete files)
|
7.71 KB,
text/html
|
Details | |
|
1.70 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
We have the known bug of not displaying an error message here, like IE7 and Opera, but this messes up the menu somehow as well.
|
Assignee | |
Comment 1•18 years ago
|
||
|
|
Assignee | |
Comment 2•18 years ago
|
||
This breaks the UI, so it looks like a serious stability problem, even though it isn't. The fix will be low-risk, so we should take it in 2.0.0.6.
Assignee: nobody → sayrer
Flags: blocking1.8.1.6?
|
||
Comment 3•18 years ago
|
||
Not a 1.8 branch blocker, but if the fix is in fact low risk write one up, get it into the trunk (or is this a branch-only problem?) and we'll look at approving it.
Flags: blocking1.8.1.7? → blocking1.8.1.7-
|
|
Assignee | |
Updated•18 years ago
|
Attachment #272447 -
Attachment mime type: application/xml → text/html
|
|
Assignee | |
Comment 4•18 years ago
|
||
Feeds that trigger fatal errors can still get events after the fatal error event. Make sure we check for nulls there.
|
|
Assignee | |
Comment 5•18 years ago
|
||
Attachment #279475 -
Attachment is obsolete: true
Attachment #279478 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 6•18 years ago
|
||
Comment on attachment 279478 [details] [diff] [review]
null checks
got confused by looking at the branch. new patch in a minute.
Attachment #279478 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Comment 7•18 years ago
|
||
OK, so trunk has had the patch from bug 350365 applied for a while now, which is the main fix for this.
Attachment #279478 -
Attachment is obsolete: true
Attachment #279485 -
Flags: review?(gavin.sharp)
|
||
Updated•18 years ago
|
Attachment #279485 -
Flags: review?(gavin.sharp) → review+
|
||
Comment 8•16 years ago
|
||
Robert: What remains to be fixed on this? It loads an empty feed instead of a broken one. Should we close this as resolved?
|
|
||
Comment 9•16 years ago
|
||
Or is there a better workaround?
|
|
||
Comment 10•12 years ago
|
||
This patch landed as http://hg.mozilla.org/mozilla-central/rev/7ebd8c4e8315. As far as I can tell this is fixed, but we still have bug 350365 for a better error UI for this.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•